From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] ARM: mvebu: Add RN104 SATA LEDs driven via NXP PCA9554
 I2C to GPIO muxer
Date: Sun, 10 Nov 2013 00:59:08 +0100
Message-ID: <527ECC4C.8080207@gmail.com>
References: <877gchmggw.fsf@natisbad.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <877gchmggw.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>, Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-Id: devicetree@vger.kernel.org

On 11/09/2013 10:07 PM, Arnaud Ebalard wrote:
> NETGEAR ReadyNAS 104 has a NXP PCA9554 I2C to GPIO chip. Among the 8 GPIO
> lines the chip makes available, four are used on the device to control
> the SATA LEDs (the four remaining ones are used for SATA disk presence).
> This patch adds DT entries for NXP PCA9554 and the four SATA GPIO LEDs.
>
> Signed-off-by: Arnaud Ebalard <arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org>
> ---
[...]
> diff --git a/arch/arm/boot/dts/armada-370-netgear-rn104.dts b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> index b0b32f5..1efc871 100644
> --- a/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> +++ b/arch/arm/boot/dts/armada-370-netgear-rn104.dts
> @@ -123,6 +123,13 @@
>   					fan_startv = <1>;
>   					pwm_polarity = <0>;
>   				};
> +
> +				pca9554: pca9554@23 {
> +					compatible = "nxp,pca9554";
> +					gpio-controller;
> +					#gpio-cells = <2>;
> +					reg = <0x23>;
> +				};
>   			};
>   		};
>   	};
> @@ -154,6 +161,30 @@
>   			gpios = <&gpio2 0 1>;    /* GPIO 64 Active Low */
>   			linux,default-trigger = "keep";
>   		};
> +
> +		sata1_led {
> +			label = "rn104:blue:sata1";
> +			gpios = <&pca9554 0 1>;  /* Active Low */

Same comment as for ReadyNAS 2120 patch:

#include <dt-bindings/gpio/gpio.h> and use GPIO_ACTIVE_HIGH/LOW.

Sebastian

> +			default-state = "off";
> +		};
> +
> +		sata2_led {
> +			label = "rn104:blue:sata2";
> +			gpios = <&pca9554 1 1>;  /* Active Low */
> +			default-state = "off";
> +		};
> +
> +		sata3_led {
> +			label = "rn104:blue:sata3";
> +			gpios = <&pca9554 2 1>;  /* Active Low */
> +			default-state = "off";
> +		};
> +
> +		sata4_led {
> +			label = "rn104:blue:sata4";
> +			gpios = <&pca9554 3 1>;  /* Active Low */
> +			default-state = "off";
> +		};
>   	};
>
>   	gpio_keys {
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html