From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alain Volmat <avolmat@me.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
Date: Fri, 3 Feb 2023 14:50:00 +0100 [thread overview]
Message-ID: <527eaa1f-f663-8a92-00b5-b0329240b922@foss.st.com> (raw)
In-Reply-To: <Y9wGO0Q//TIKwTTE@google.com>
On 2/2/23 19:51, Dmitry Torokhov wrote:
> On Fri, Sep 30, 2022 at 09:00:41AM -0700, Dmitry Torokhov wrote:
>> According to c8sectpfe driver code we first drive reset line low and
>> then high to reset the port, therefore the reset line is supposed to
>> be annotated as "active low". This will be important when we convert
>> the driver to gpiod API.
>>
>> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>
> Gentle ping on this one...
Hi Dmitry
Sorry for the delay, i will push a STi pull request including your patch.
Patrice
>
>>
>> v2: fixed typo in the subject, added Patrice's reviewed-by
>>
>> arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
>> index 2aa94605d3d4..d52a7aaa1074 100644
>> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
>> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
>> @@ -178,7 +178,7 @@ tsin0: port {
>> tsin-num = <0>;
>> serial-not-parallel;
>> i2c-bus = <&ssc2>;
>> - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
>> + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
>> dvb-card = <STV0367_TDA18212_NIMA_1>;
>> };
>> };
>> --
>> 2.38.0.rc1.362.ged0d419d3c-goog
>>
>>
>> --
>> Dmitry
>
prev parent reply other threads:[~2023-02-03 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 16:00 [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Dmitry Torokhov
2023-02-02 18:51 ` Dmitry Torokhov
2023-02-03 13:50 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527eaa1f-f663-8a92-00b5-b0329240b922@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=avolmat@me.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).