From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tarek Dakhran Subject: Re: [PATCH v3 4/4] ARM: dts: Add initial device tree support for EXYNOS5410 Date: Mon, 11 Nov 2013 12:03:07 +0400 Message-ID: <52808F3B.2000804@samsung.com> References: <1383811969-32712-1-git-send-email-v.tyrtov@samsung.com> <1383811969-32712-5-git-send-email-v.tyrtov@samsung.com> <19495187.Nrl1zS8Kog@flatron> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <19495187.Nrl1zS8Kog@flatron> Sender: linux-doc-owner@vger.kernel.org To: Tomasz Figa , Vyacheslav Tyrtov Cc: linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Kukjin Kim , Russell King , Ben Dooks , Mike Turquette , Daniel Lezcano , Thomas Gleixner , Heiko Stuebner , Naour Romain , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Dave.Martin@arm.com, nicolas.pitre@linaro.org List-Id: devicetree@vger.kernel.org Hi, On 10.11.2013 22:02, Tomasz Figa wrote: > Hi, > > Please see my comments inline. > > On Thursday 07 of November 2013 12:12:49 Vyacheslav Tyrtov wrote: >> From: Tarek Dakhran >> >> Add initial device tree nodes for EXYNOS5410 SoC and SMDK5410 board. >> >> Signed-off-by: Tarek Dakhran >> Signed-off-by: Vyacheslav Tyrtov >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/exynos5410-smdk5410.dts | 65 ++++++++++ >> arch/arm/boot/dts/exynos5410.dtsi | 209 ++++++++++++++++++++++++++++++ >> 3 files changed, 275 insertions(+) >> create mode 100644 arch/arm/boot/dts/exynos5410-smdk5410.dts >> create mode 100644 arch/arm/boot/dts/exynos5410.dtsi > [snip] >> diff --git a/arch/arm/boot/dts/exynos5410-smdk5410.dts b/arch/arm/boot/dts/exynos5410-smdk5410.dts >> new file mode 100644 >> index 0000000..06ae479 >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts >> @@ -0,0 +1,65 @@ >> +/* >> + * SAMSUNG SMDK5410 board device tree source >> + * >> + * Copyright (c) 2013 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> +*/ >> + >> +/dts-v1/; >> +#include "exynos5410.dtsi" >> +/ { >> + model = "Samsung SMDK5410 board based on EXYNOS5410"; >> + compatible = "samsung,smdk5410", "samsung,exynos5410"; >> + >> + memory { >> + reg = <0x40000000 0x80000000>; >> + }; >> + >> + chosen { >> + bootargs = "console=ttySAC2,115200"; >> + }; >> + >> + oscclk: oscclk { > coding style: According to ePAPR recommendation, node name should > represent hardware type, not particular instance of hardware. > > So instead, the preferred way would be to specify the clock using > following layout: > > clocks { > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <0>; > > oscclk: clock@0 { > compatible = "fixed-clock"; > reg = <0>; > #clock-cells = <0>; > clock-frequency = <24000000>; > clock-output-names = "fin_pll"; > }; > }; > >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <24000000>; >> + clock-output-names = "fin_pll"; >> + }; > [snip] >> + >> +}; >> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi >> new file mode 100644 >> index 0000000..9921b66 >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos5410.dtsi >> @@ -0,0 +1,209 @@ >> +/* >> + * SAMSUNG EXYNOS5410 SoC device tree source >> + * >> + * Copyright (c) 2013 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * SAMSUNG EXYNOS5410 SoC device nodes are listed in this file. >> + * EXYNOS5410 based board files can include this file and provide >> + * values for board specfic bindings. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include >> +#include "exynos5.dtsi" >> +/ { > [snip] >> + clock: clock-controller@10010000 { >> + compatible = "samsung,exynos5410-clock"; >> + reg = <0x10010000 0x30000>; >> + #clock-cells = <1>; >> + }; >> + >> + mct@101C0000 { > A generic name would be: timer@101C0000 > >> + compatible = "samsung,exynos4210-mct"; >> + reg = <0x101C0000 0xB00>; >> + interrupt-controller; >> + #interrups-cells = <1>; > MCT is not an interrupt controller, so both interrupt-controller and > #interrupt-cells properties are incorrect. I guess that's due to the > broken example in the documentation, that I already posted patches to fix. > >> + interrupt-parent = <&mct_map>; >> + interrupts = <0>, <1>, <2>, <3>, >> + <4>, <5>, <6>, <7>, >> + <8>, <9>, <10>, <11>; >> + clocks = <&oscclk>, <&clock CLK_MCT>; >> + clock-names = "fin_pll", "mct"; >> + >> + mct_map: mct-map { > Again, interrupt-map would be a better name for this node. > >> + #interrupt-cells = <1>; >> + #address-cells = <0>; >> + #size-cells = <0>; >> + interrupt-map = <0 &combiner 23 3>, >> + <1 &combiner 23 4>, >> + <2 &combiner 25 2>, >> + <3 &combiner 25 3>, >> + <4 &gic 0 120 0>, >> + <5 &gic 0 121 0>, >> + <6 &gic 0 122 0>, >> + <7 &gic 0 123 0>, >> + <8 &gic 0 128 0>, >> + <9 &gic 0 129 0>, >> + <10 &gic 0 130 0>, >> + <11 &gic 0 131 0>; >> + }; >> + }; > Otherwise, the patch looks good. > > Best regards, > Tomasz > > Thanks a lot, Tomasz. All will be corrected in v4. Best regards, Tarek Dakhran