From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas kandagatla Subject: Re: [PATCH RFC 07/10] PM / wakeup : Introduce device_child_may_wakeup Date: Tue, 12 Nov 2013 14:09:01 +0000 Message-ID: <5282367D.1090705@st.com> References: <1384264311-7308-1-git-send-email-srinivas.kandagatla@st.com> <1384264377-7609-1-git-send-email-srinivas.kandagatla@st.com> <4093206.klj58BXQv3@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4093206.klj58BXQv3@vostro.rjw.lan> Sender: linux-doc-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Stuart Menefy , Pavel Machek , Len Brown , stephen.gallimore@st.com, Greg Kroah-Hartman , Giuseppe Cavallaro , Grant Likely , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, linux-pm@vger.kernel.org List-Id: devicetree@vger.kernel.org On 12/11/13 14:20, Rafael J. Wysocki wrote: >> >> > +/* callback for device_child_may_wakeup */ >> > +static int __device_child_may_wakeup(struct device *dev, void *c) >> > +{ >> > + return device_may_wakeup(dev); >> > +} > This doesn't have anything to do with children in principle, so please call > it differently. Something like device_may_wakeup_cb() would work for me (and > then you may not need the comment even). Thanks Rafael, I will fix this in next version. > > Thanks! > >> > + >> > +/**