From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Haojian Zhuang
<haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 4/4] arm: pxa: add non device-tree timer link to clocksource
Date: Sat, 05 Jul 2014 20:29:40 +0200 [thread overview]
Message-ID: <5284586.j08GjTMeo6@wuerfel> (raw)
In-Reply-To: <1404558781-9537-4-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
On Saturday 05 July 2014 13:13:01 Robert Jarzmik wrote:
> EXPORT_SYMBOL(get_clock_tick_rate);
>
> /*
> + * For non device-tree builds, keep legacy timer init
> + */
> +extern void pxa_timer_nodt_init(int irq, void __iomem *base,
> + unsigned long clock_tick_rate);
> +void pxa_timer_init(void)
> +{
> + pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000),
> + get_clock_tick_rate());
> +}
> +
I think it would be better to move the extern declaration into
a new header file, e.g. include/clocksource/pxa.h.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-05 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 11:12 [PATCH v2 1/4] clocksource: move PXA timer to clocksource framework Robert Jarzmik
[not found] ` <1404558781-9537-1-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-07-05 11:12 ` [PATCH v2 2/4] clocksource: add device-tree support for PXA timer Robert Jarzmik
2014-07-05 11:13 ` [PATCH v2 4/4] arm: pxa: add non device-tree timer link to clocksource Robert Jarzmik
[not found] ` <1404558781-9537-4-git-send-email-robert.jarzmik-GANU6spQydw@public.gmane.org>
2014-07-05 18:29 ` Arnd Bergmann [this message]
2014-07-05 11:13 ` [PATCH v2 3/4] arm: pxa: add CLKSRC_OF dependency Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284586.j08GjTMeo6@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robert.jarzmik-GANU6spQydw@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox