* Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com> @ 2013-11-06 11:32 ` ivan.khoronzhuk [not found] ` <527A28E8.4010204-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: ivan.khoronzhuk @ 2013-11-06 11:32 UTC (permalink / raw) To: Santosh Shilimkar, wim, nsekhar, linux-watchdog, devicetree Cc: grant.likely, rob.herring, pawel.moll, mark.rutland, swarren, galak, ijc+devicetree, linux-kernel, linux-arm-kernel The Keystone arch is using clocks in DT and source clock for watchdog has to be specified, so add this to binding. Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com> --- .../devicetree/bindings/watchdog/davinci-wdt.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt index fddced9..4db4d0e 100644 --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt @@ -7,6 +7,10 @@ Required properties: - reg : Should contain WDT registers location and length +- clocks: phandle reference to the controller clock. + Required only for Keystone arch. + See clock-bindings.txt + Optional properties: - timeout-sec: Contains the watchdog timeout in seconds @@ -21,4 +25,5 @@ wdt: wdt@2320000 { compatible = "ti,davinci-wdt"; reg = <0x02320000 0x80>; timeout-sec = <30>; + clocks = <&clkwdtimer0>; }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <527A28E8.4010204-l0cyMroinI0@public.gmane.org>]
* Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] ` <527A28E8.4010204-l0cyMroinI0@public.gmane.org> @ 2013-11-12 15:40 ` Santosh Shilimkar 2013-11-17 2:28 ` Guenter Roeck 2013-11-23 17:57 ` Arnd Bergmann 2 siblings, 0 replies; 8+ messages in thread From: Santosh Shilimkar @ 2013-11-12 15:40 UTC (permalink / raw) To: ivan.khoronzhuk Cc: wim-IQzOog9fTRqzQB+pC5nmwQ, nsekhar-l0cyMroinI0, linux-watchdog-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, grant.likely-QSEj5FYQhm4dnm+yROfE0A, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, swarren-3lzwWm7+Weoh9ZMKESR00Q, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wednesday 06 November 2013 06:32 AM, ivan.khoronzhuk wrote: > The Keystone arch is using clocks in DT and source clock for watchdog > has to be specified, so add this to binding. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org> > --- Acked-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] ` <527A28E8.4010204-l0cyMroinI0@public.gmane.org> 2013-11-12 15:40 ` Santosh Shilimkar @ 2013-11-17 2:28 ` Guenter Roeck [not found] ` <528829DB.7020003-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> 2013-11-23 17:57 ` Arnd Bergmann 2 siblings, 1 reply; 8+ messages in thread From: Guenter Roeck @ 2013-11-17 2:28 UTC (permalink / raw) To: ivan.khoronzhuk, Santosh Shilimkar, wim-IQzOog9fTRqzQB+pC5nmwQ, nsekhar-l0cyMroinI0, linux-watchdog-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, swarren-3lzwWm7+Weoh9ZMKESR00Q, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 11/06/2013 03:32 AM, ivan.khoronzhuk wrote: > The Keystone arch is using clocks in DT and source clock for watchdog > has to be specified, so add this to binding. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org> > --- > .../devicetree/bindings/watchdog/davinci-wdt.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > index fddced9..4db4d0e 100644 > --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt > @@ -7,6 +7,10 @@ Required properties: > > - reg : Should contain WDT registers location and length > > +- clocks: phandle reference to the controller clock. > + Required only for Keystone arch. > + See clock-bindings.txt > + Yet another form of formatting. Also, wonder if it makes sense to merge this with the patch adding keystone support. > Optional properties: > > - timeout-sec: Contains the watchdog timeout in seconds > @@ -21,4 +25,5 @@ wdt: wdt@2320000 { > compatible = "ti,davinci-wdt"; > reg = <0x02320000 0x80>; > timeout-sec = <30>; > + clocks = <&clkwdtimer0>; > }; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <528829DB.7020003-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>]
* Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] ` <528829DB.7020003-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> @ 2013-11-18 15:26 ` ivan.khoronzhuk 0 siblings, 0 replies; 8+ messages in thread From: ivan.khoronzhuk @ 2013-11-18 15:26 UTC (permalink / raw) To: Guenter Roeck, Santosh Shilimkar, wim-IQzOog9fTRqzQB+pC5nmwQ, nsekhar-l0cyMroinI0, linux-watchdog-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, swarren-3lzwWm7+Weoh9ZMKESR00Q, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 11/17/2013 04:28 AM, Guenter Roeck wrote: > On 11/06/2013 03:32 AM, ivan.khoronzhuk wrote: >> The Keystone arch is using clocks in DT and source clock for watchdog >> has to be specified, so add this to binding. >> >> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org> >> --- >> .../devicetree/bindings/watchdog/davinci-wdt.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt >> b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt >> index fddced9..4db4d0e 100644 >> --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt >> @@ -7,6 +7,10 @@ Required properties: >> >> - reg : Should contain WDT registers location and length >> >> +- clocks: phandle reference to the controller clock. >> + Required only for Keystone arch. >> + See clock-bindings.txt >> + > > Yet another form of formatting. Also, wonder if it makes sense to merge > this with the patch adding keystone support. > Ok, I'll squash them. >> Optional properties: >> >> - timeout-sec: Contains the watchdog timeout in seconds >> @@ -21,4 +25,5 @@ wdt: wdt@2320000 { >> compatible = "ti,davinci-wdt"; >> reg = <0x02320000 0x80>; >> timeout-sec = <30>; >> + clocks = <&clkwdtimer0>; >> }; >> > -- Regards, Ivan Khoronzhuk -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] ` <527A28E8.4010204-l0cyMroinI0@public.gmane.org> 2013-11-12 15:40 ` Santosh Shilimkar 2013-11-17 2:28 ` Guenter Roeck @ 2013-11-23 17:57 ` Arnd Bergmann [not found] ` <201311231857.47104.arnd-r2nGTMty4D4@public.gmane.org> 2 siblings, 1 reply; 8+ messages in thread From: Arnd Bergmann @ 2013-11-23 17:57 UTC (permalink / raw) To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: ivan.khoronzhuk, Santosh Shilimkar, wim-IQzOog9fTRqzQB+pC5nmwQ, nsekhar-l0cyMroinI0, linux-watchdog-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8, pawel.moll-5wv7dgnIgG8, swarren-3lzwWm7+Weoh9ZMKESR00Q, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA, grant.likely-QSEj5FYQhm4dnm+yROfE0A On Wednesday 06 November 2013, ivan.khoronzhuk wrote: > @@ -7,6 +7,10 @@ Required properties: > > - reg : Should contain WDT registers location and length > > +- clocks: phandle reference to the controller clock. > + Required only for Keystone arch. > + See clock-bindings.txt > + > Optional properties: > > - timeout-sec: Contains the watchdog timeout in seconds I think it should really be listed under "Optional properties" and the reference to Keystone removed. Note how the binding would need to change otherwise if another platform started to use the clock, which is a little silly. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <201311231857.47104.arnd-r2nGTMty4D4@public.gmane.org>]
* Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] ` <201311231857.47104.arnd-r2nGTMty4D4@public.gmane.org> @ 2013-11-25 10:59 ` ivan.khoronzhuk [not found] ` <52932DA1.8040204-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: ivan.khoronzhuk @ 2013-11-25 10:59 UTC (permalink / raw) To: Arnd Bergmann, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: Santosh Shilimkar, wim-IQzOog9fTRqzQB+pC5nmwQ, nsekhar-l0cyMroinI0, linux-watchdog-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8, pawel.moll-5wv7dgnIgG8, swarren-3lzwWm7+Weoh9ZMKESR00Q, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA, grant.likely-QSEj5FYQhm4dnm+yROfE0A On 11/23/2013 07:57 PM, Arnd Bergmann wrote: > On Wednesday 06 November 2013, ivan.khoronzhuk wrote: >> @@ -7,6 +7,10 @@ Required properties: >> >> - reg : Should contain WDT registers location and length >> >> +- clocks: phandle reference to the controller clock. >> + Required only for Keystone arch. >> + See clock-bindings.txt >> + >> Optional properties: >> >> - timeout-sec: Contains the watchdog timeout in seconds > > I think it should really be listed under "Optional properties" and the > reference to Keystone removed. Note how the binding would need > to change otherwise if another platform started to use the clock, which > is a little silly. > > Arnd > Ok, I'll move clocks property under "Optional properties" and describe it as following: Optional properties: - timeout-sec : Contains the watchdog timeout in seconds - clocks: phandle reference to the controller clock. Needed if platform uses clocks. See clock-bindings.txt FYI: The new patch series had been already presented, where the patches "watchdog: davinci: add "clocks" property" and "watchdog: davinci: reuse driver for keystone arch" were combined. http://www.spinics.net/lists/devicetree/msg12542.html -- Regards, Ivan Khoronzhuk -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <52932DA1.8040204-l0cyMroinI0@public.gmane.org>]
* Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] ` <52932DA1.8040204-l0cyMroinI0@public.gmane.org> @ 2013-11-25 12:15 ` Mark Rutland [not found] ` <20131125121529.GE32081-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: Mark Rutland @ 2013-11-25 12:15 UTC (permalink / raw) To: ivan.khoronzhuk Cc: Arnd Bergmann, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Santosh Shilimkar, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org On Mon, Nov 25, 2013 at 10:59:45AM +0000, ivan.khoronzhuk wrote: > On 11/23/2013 07:57 PM, Arnd Bergmann wrote: > > On Wednesday 06 November 2013, ivan.khoronzhuk wrote: > >> @@ -7,6 +7,10 @@ Required properties: > >> > >> - reg : Should contain WDT registers location and length > >> > >> +- clocks: phandle reference to the controller clock. > >> + Required only for Keystone arch. > >> + See clock-bindings.txt > >> + > >> Optional properties: > >> > >> - timeout-sec: Contains the watchdog timeout in seconds > > > > I think it should really be listed under "Optional properties" and the > > reference to Keystone removed. Note how the binding would need > > to change otherwise if another platform started to use the clock, which > > is a little silly. > > > > Arnd > > > > Ok, I'll move clocks property under "Optional properties" and describe it > as following: > > Optional properties: > - timeout-sec : Contains the watchdog timeout in seconds > - clocks: phandle reference to the controller clock. > Needed if platform uses clocks. > See clock-bindings.txt Nit: clocks aren't just phandles, they have a clock-specifier too (which might be 0 cells). Otherwise this looks fine to me. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20131125121529.GE32081-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>]
* Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property [not found] ` <20131125121529.GE32081-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> @ 2013-11-25 12:41 ` ivan.khoronzhuk 0 siblings, 0 replies; 8+ messages in thread From: ivan.khoronzhuk @ 2013-11-25 12:41 UTC (permalink / raw) To: Mark Rutland Cc: Arnd Bergmann, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Santosh Shilimkar, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org On 11/25/2013 02:15 PM, Mark Rutland wrote: > On Mon, Nov 25, 2013 at 10:59:45AM +0000, ivan.khoronzhuk wrote: >> On 11/23/2013 07:57 PM, Arnd Bergmann wrote: >>> On Wednesday 06 November 2013, ivan.khoronzhuk wrote: >>>> @@ -7,6 +7,10 @@ Required properties: >>>> >>>> - reg : Should contain WDT registers location and length >>>> >>>> +- clocks: phandle reference to the controller clock. >>>> + Required only for Keystone arch. >>>> + See clock-bindings.txt >>>> + >>>> Optional properties: >>>> >>>> - timeout-sec: Contains the watchdog timeout in seconds >>> >>> I think it should really be listed under "Optional properties" and the >>> reference to Keystone removed. Note how the binding would need >>> to change otherwise if another platform started to use the clock, which >>> is a little silly. >>> >>> Arnd >>> >> >> Ok, I'll move clocks property under "Optional properties" and describe it >> as following: >> >> Optional properties: >> - timeout-sec : Contains the watchdog timeout in seconds >> - clocks: phandle reference to the controller clock. >> Needed if platform uses clocks. >> See clock-bindings.txt > > Nit: clocks aren't just phandles, they have a clock-specifier too (which > might be 0 cells). > > Otherwise this looks fine to me. > > Mark. > ... I will replace it to: Optional properties: - timeout-sec : Contains the watchdog timeout in seconds - clocks: the clock feeding the watchdog timer. Needed if platform uses clocks. See clock-bindings.txt Is it OK? -- Regards, Ivan Khoronzhuk -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-11-25 12:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-06 11:32 ` Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property ivan.khoronzhuk
[not found] ` <527A28E8.4010204-l0cyMroinI0@public.gmane.org>
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-17 2:28 ` Guenter Roeck
[not found] ` <528829DB.7020003-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-11-18 15:26 ` ivan.khoronzhuk
2013-11-23 17:57 ` Arnd Bergmann
[not found] ` <201311231857.47104.arnd-r2nGTMty4D4@public.gmane.org>
2013-11-25 10:59 ` ivan.khoronzhuk
[not found] ` <52932DA1.8040204-l0cyMroinI0@public.gmane.org>
2013-11-25 12:15 ` Mark Rutland
[not found] ` <20131125121529.GE32081-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-11-25 12:41 ` ivan.khoronzhuk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).