Re: [PATCHv5 10/20] arm: dts: add omap4430 thermal data

From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, wni@nvidia.com,
	durgadoss.r@intel.com, ian.campbell@citrix.com,
	pawel.moll@arm.com, swarren@wwwdotorg.org,
	"Tony Lindgren" <tony@atomide.com>,
	devicetree-discuss@lists.ozlabs.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
	lm-sensors@lm-sensors.org,
	"Eduardo Valentin" <eduardo.valentin@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	grant.likely@linaro.org, "Russell King" <linux@arm.linux.org.uk>,
	rui.zhang@intel.com, linux-omap@vger.kernel.org,
	linux@roeck-us.net
Subject: Re: [PATCHv5 10/20] arm: dts: add omap4430 thermal data
Date: Thu, 21 Nov 2013 11:36:13 -0400	[thread overview]
Message-ID: <528E286D.50100@ti.com> (raw)
In-Reply-To: <20131120123245.GA3242@amd.pavel.ucw.cz>

[-- Attachment #1.1: Type: text/plain, Size: 1873 bytes --]

On 20-11-2013 08:32, Pavel Machek wrote:
> HI!
> 
>> This patch changes the dtsi entry on omap4430 to contain
>> the thermal data. This data will enable the passive
>> cooling with CPUfreq cooling device at 100C and the
>> system will do a thermal shutdown at 125C.
>>
>> Cc: "Benoît Cousson" <bcousson@baylibre.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: linux-omap@vger.kernel.org
>> Cc: devicetree-discuss@lists.ozlabs.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
>> ---
>>  arch/arm/boot/dts/omap443x.dtsi | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi
>> index bcf455e..e9c97d6 100644
>> --- a/arch/arm/boot/dts/omap443x.dtsi
>> +++ b/arch/arm/boot/dts/omap443x.dtsi
>> @@ -12,7 +12,7 @@
>>  
>>  / {
>>  	cpus {
>> -		cpu@0 {
>> +		cpu0: cpu@0 {
>>  			/* OMAP443x variants OPP50-OPPNT */
>>  			operating-points = <
>>  				/* kHz    uV */
> 
> I see you also add labels to various other entries...

I think I didn't quite get your point here. Can you please elaborate?

This label has been added because it will be used in thermal zone while
referencing the cooling device.

> 
>> @@ -25,9 +25,15 @@
>>  		};
>>  	};
>>  
>> -	bandgap {
>> +	thermal-zones{
> 
> You may want to include space here.

OK.

> 
>> +		#include "omap4-cpu-thermal.dtsi"
>> +	};
>> +
>> +	bandgap: bandgap {
>>  		reg = <0x4a002260 0x4
>>  		       0x4a00232C 0x4>;
>>  		compatible = "ti,omap4430-bandgap";
>> +
>> +		#thermal-sensor-cells = <0>;
>>  	};
>>  };
> 

-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel