[PATCH] dt-bindings: add ARMv8 PMU binding

[PATCH] dt-bindings: add ARMv8 PMU binding

[Rob Herring]

From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>

Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.

Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
---
 Documentation/devicetree/bindings/arm/pmu.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
index 343781b..3e1e498 100644
--- a/Documentation/devicetree/bindings/arm/pmu.txt
+++ b/Documentation/devicetree/bindings/arm/pmu.txt
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
 Required properties:
 
 - compatible : should be one of
+	"arm,armv8-pmuv3"
 	"arm,cortex-a15-pmu"
 	"arm,cortex-a9-pmu"
 	"arm,cortex-a8-pmu"
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: add ARMv8 PMU binding

[Kumar Gala]

On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> 
> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
> 
> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
> ---
> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> index 343781b..3e1e498 100644
> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> Required properties:
> 
> - compatible : should be one of
> +	"arm,armv8-pmuv3”

what about arm,armv8-pmu-v3?

- k

> 	"arm,cortex-a15-pmu"
> 	"arm,cortex-a9-pmu"
> 	"arm,cortex-a8-pmu"
> -- 
> 1.8.1.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: add ARMv8 PMU binding

[Rob Herring]

On 11/22/2013 03:38 PM, Kumar Gala wrote:
> 
> On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 
>> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>>
>> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
>>
>> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
>> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
>> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
>> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
>> ---
>> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
>> index 343781b..3e1e498 100644
>> --- a/Documentation/devicetree/bindings/arm/pmu.txt
>> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
>> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
>> Required properties:
>>
>> - compatible : should be one of
>> +	"arm,armv8-pmuv3”
> 
> what about arm,armv8-pmu-v3?

I'm just documenting what is already being used:

arch/arm64/boot/dts/foundation-v8.dts:          compatible =
"arm,armv8-pmuv3";
arch/arm64/boot/dts/rtsm_ve-aemv8a.dts:         compatible =
"arm,armv8-pmuv3";

Do we want to change those?

Rob

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: add ARMv8 PMU binding

[Mark Rutland]

On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
> On 11/22/2013 03:38 PM, Kumar Gala wrote:
> > 
> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > 
> >> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> >>
> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
> >>
> >> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> >> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> >> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
> >> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> >> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
> >> ---
> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> >> index 343781b..3e1e498 100644
> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> >> Required properties:
> >>
> >> - compatible : should be one of
> >> +	"arm,armv8-pmuv3”
> > 
> > what about arm,armv8-pmu-v3?
> 
> I'm just documenting what is already being used:
> 
> arch/arm64/boot/dts/foundation-v8.dts:          compatible =
> "arm,armv8-pmuv3";
> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts:         compatible =
> "arm,armv8-pmuv3";
> 
> Do we want to change those?

It would probably have been nicer to have the '-' from the start, but
adding it now is only going to expand the set of compatible strings for
no appreciable benefit.

I don't see any value in adding a new form of the string, and we can't
change the existing one as it's already in use.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: add ARMv8 PMU binding

[Rob Herring]

On Mon, Nov 25, 2013 at 3:16 AM, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
>> On 11/22/2013 03:38 PM, Kumar Gala wrote:
>> >
>> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> >
>> >> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> >>
>> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
>> >>
>> >> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>> >> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
>> >> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
>> >> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
>> >> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
>> >> ---
>> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
>> >> 1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
>> >> index 343781b..3e1e498 100644
>> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
>> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
>> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
>> >> Required properties:
>> >>
>> >> - compatible : should be one of
>> >> +  "arm,armv8-pmuv3”
>> >
>> > what about arm,armv8-pmu-v3?
>>
>> I'm just documenting what is already being used:
>>
>> arch/arm64/boot/dts/foundation-v8.dts:          compatible =
>> "arm,armv8-pmuv3";
>> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts:         compatible =
>> "arm,armv8-pmuv3";
>>
>> Do we want to change those?
>
> It would probably have been nicer to have the '-' from the start, but
> adding it now is only going to expand the set of compatible strings for
> no appreciable benefit.
>
> I don't see any value in adding a new form of the string, and we can't
> change the existing one as it's already in use.

Is that an ack then?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dt-bindings: add ARMv8 PMU binding

[Mark Rutland]

On Mon, Nov 25, 2013 at 03:24:46PM +0000, Rob Herring wrote:
> On Mon, Nov 25, 2013 at 3:16 AM, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> wrote:
> > On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
> >> On 11/22/2013 03:38 PM, Kumar Gala wrote:
> >> >
> >> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >> >
> >> >> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> >> >>
> >> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
> >> >>
> >> >> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> >> >> Cc: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> >> >> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
> >> >> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> >> >> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
> >> >> ---
> >> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> >> >> 1 file changed, 1 insertion(+)
> >> >>
> >> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> index 343781b..3e1e498 100644
> >> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> >> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> >> >> Required properties:
> >> >>
> >> >> - compatible : should be one of
> >> >> +  "arm,armv8-pmuv3”
> >> >
> >> > what about arm,armv8-pmu-v3?
> >>
> >> I'm just documenting what is already being used:
> >>
> >> arch/arm64/boot/dts/foundation-v8.dts:          compatible =
> >> "arm,armv8-pmuv3";
> >> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts:         compatible =
> >> "arm,armv8-pmuv3";
> >>
> >> Do we want to change those?
> >
> > It would probably have been nicer to have the '-' from the start, but
> > adding it now is only going to expand the set of compatible strings for
> > no appreciable benefit.
> >
> > I don't see any value in adding a new form of the string, and we can't
> > change the existing one as it's already in use.
> 
> Is that an ack then?
> 

Sure:

Acked-by: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>

Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html