devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sebastian Reichel <sre@debian.org>,
	Sebastian Reichel <sre@ring0.de>,
	linux-iio@vger.kernel.org
Cc: Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Landley <rob@landley.net>, Jonathan Cameron <jic23@cam.ac.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bill Pemberton <wfp5p@virginia.edu>,
	Sachin Kamat <sachin.kamat@linaro.org>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3] iio:light:tsl2563: Add DT support
Date: Sat, 23 Nov 2013 11:52:22 +0000	[thread overview]
Message-ID: <529096F6.3040202@kernel.org> (raw)
In-Reply-To: <1382692210-9692-1-git-send-email-sre@debian.org>

On 10/25/13 10:10, Sebastian Reichel wrote:
> Add Device Tree support for the TSL2563 driver,
> document the binding and add AMS-TAOS Inc. to the
> list of vendor prefixes.
> 
> Signed-off-by: Sebastian Reichel <sre@debian.org>
> Acked-by: Kumar Gala <galak@codeaurora.org>
Applied to the togreg branch of iio.git with the minor change Grant pointed out
to not use the indexed version of the of_property_read_u32

Thanks all,

Jonathan
> ---
>  .../devicetree/bindings/iio/light/tsl2563.txt         | 19 +++++++++++++++++++
>  Documentation/devicetree/bindings/vendor-prefixes.txt |  1 +
>  drivers/iio/light/tsl2563.c                           |  4 ++++
>  3 files changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2563.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2563.txt b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
> new file mode 100644
> index 0000000..f91e809
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
> @@ -0,0 +1,19 @@
> +* AMS TAOS TSL2563 ambient light sensor
> +
> +Required properties:
> +
> +  - compatible : should be "amstaos,tsl2563"
> +  - reg : the I2C address of the sensor
> +
> +Optional properties:
> +
> +  - amstaos,cover-comp-gain : integer used as multiplier for gain
> +                              compensation (default = 1)
> +
> +Example:
> +
> +tsl2563@29 {
> +	compatible = "amstaos,tsl2563";
> +	reg = <0x29>;
> +	amstaos,cover-comp-gain = <16>;
> +};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 2cc3dad..8cf3edf 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -9,6 +9,7 @@ aeroflexgaisler	Aeroflex Gaisler AB
>  ak	Asahi Kasei Corp.
>  altr	Altera Corp.
>  amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
> +amstaos	AMS-Taos Inc.
>  apm	Applied Micro Circuits Corporation (APM)
>  arm	ARM Ltd.
>  atmel	Atmel Corporation
> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
> index ebb962c..261660a 100644
> --- a/drivers/iio/light/tsl2563.c
> +++ b/drivers/iio/light/tsl2563.c
> @@ -699,6 +699,7 @@ static int tsl2563_probe(struct i2c_client *client,
>  	struct iio_dev *indio_dev;
>  	struct tsl2563_chip *chip;
>  	struct tsl2563_platform_data *pdata = client->dev.platform_data;
> +	struct device_node *np = client->dev.of_node;
>  	int err = 0;
>  	u8 id = 0;
>  
> @@ -735,6 +736,9 @@ static int tsl2563_probe(struct i2c_client *client,
>  
>  	if (pdata)
>  		chip->cover_comp_gain = pdata->cover_comp_gain;
> +	else if (np)
> +		of_property_read_u32_index(np, "amstaos,cover-comp-gain", 0,
> +							&chip->cover_comp_gain);
>  	else
>  		chip->cover_comp_gain = 1;
>  
> 

  reply	other threads:[~2013-11-23 11:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23 21:51 [PATCH] iio:light:tsl2563: Add DT support Sebastian Reichel
     [not found] ` <1382565063-17083-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2013-10-24  8:29   ` Jonathan Cameron
     [not found]     ` <5268DA76.6060503-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-10-24 13:43       ` Sebastian Reichel
2013-10-24 13:58         ` Jon Brenner
     [not found]           ` <3C879D35B299F147B1DEDFBEE12F2E06012E5631C1-w6KWF4XPi0fT3vPUD1ni5ZoqS/4htBe4AL8bYrjMMd8@public.gmane.org>
2013-10-24 15:13             ` Jonathan Cameron
2013-10-24 14:27   ` [PATCHv2] " Sebastian Reichel
     [not found]     ` <1382624835-10228-1-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2013-10-25  3:32       ` Kumar Gala
2013-10-25  8:23         ` Sebastian Reichel
2013-10-25  8:37           ` Kumar Gala
2013-10-25  9:10 ` [PATCHv3] " Sebastian Reichel
2013-11-23 11:52   ` Jonathan Cameron [this message]
2013-10-25 19:10 ` [PATCH] " Grant Likely
     [not found]   ` <20131025191028.8C140C40422-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-10-25 23:09     ` Sebastian Reichel
2013-11-23 11:50       ` Jonathan Cameron
     [not found]         ` <52909685.6040606-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-11-23 12:06           ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529096F6.3040202@kernel.org \
    --to=jic23@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jic23@cam.ac.uk \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=sachin.kamat@linaro.org \
    --cc=sre@debian.org \
    --cc=sre@ring0.de \
    --cc=swarren@wwwdotorg.org \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).