From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ivan.khoronzhuk" Subject: Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core Date: Mon, 25 Nov 2013 16:56:43 +0200 Message-ID: <5293652B.80402@ti.com> References: <1385388285-10553-1-git-send-email-ivan.khoronzhuk@ti.com> <1385388285-10553-2-git-send-email-ivan.khoronzhuk@ti.com> <52935BAD.9080908@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52935BAD.9080908@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Santosh Shilimkar Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, linux-watchdog@vger.kernel.org, Pawel Moll , swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, nsekhar@ti.com, galak@kernel.crashing.org, rob.herring@calxeda.com, linux-kernel@vger.kernel.org, wim@iguana.be, grant.likely@linaro.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 11/25/2013 04:16 PM, Santosh Shilimkar wrote: > Ivan, > > On Monday 25 November 2013 09:04 AM, Ivan Khoronzhuk wrote: >> To reduce code duplicate and increase code readability use WDT core >> code to handle WDT interface. >> >> Remove io_lock as the WDT core uses mutex to lock each wdt device. >> Remove wdt_state as the WDT core tracks state with its own variable. >> >> The watchdog_init_timeout() can read timeout value from timeout-sec >> property if the passed value is out of bounds. The heartbeat is >> initialized in next way. If heartbeat is not set thought module >> parameter, try to read it's value from WDT node timeout-sec property. >> If node has no one, use default value. >> >> The heartbeat is hold in wdd->timeout by WDT core, so use it in >> order to set timeout period. >> >> Signed-off-by: Ivan Khoronzhuk >> Acked-by: Santosh Shilimkar >> Reviewed-by: Guenter Roeck > > Minor suggestion regarding the SOB line which applies to > rest of the series as well. Typically your SOB line > should be the last one like below. > > Acked-by: Santosh Shilimkar > Reviewed-by: Guenter Roeck > Signed-off-by: Ivan Khoronzhuk > > No need to repost the series just for that. The last > patch as I commented earlier, needs to be separate > patch which will go via linux-keystone tree. > > Once the watchdog maintainer is happy with rest of the > series and applies it, I will pick last patch. > > Regards, > Santosh > Thanks, Santosh I'll take note. -- Regards, Ivan Khoronzhuk