From: Michal Simek <monstr@monstr.eu>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: Chris Ball <cjb@laptop.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Michal Simek <michal.simek@xilinx.com>,
Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v2 1/2] mmc: arasan: Add driver for Arasan SDHCI
Date: Wed, 27 Nov 2013 06:28:05 +0100 [thread overview]
Message-ID: <529582E5.4010809@monstr.eu> (raw)
In-Reply-To: <9e92f3b2-5434-4fcf-b7f5-3f634175193c@CO1EHSMHS024.ehs.local>
[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]
Hi Chris,
On 11/27/2013 12:39 AM, Sören Brinkmann wrote:
> Hi Chris,
>
> On Tue, Nov 26, 2013 at 06:22:46PM -0500, Chris Ball wrote:
>> Hi Soren, sorry for the late review, just trivial changes:
> No problem. Thanks for looking at it.
>
>>
>> On Wed, Oct 30 2013, Soren Brinkmann wrote:
>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> new file mode 100644
>>> index 000000000000..ef4c5ac753e8
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> @@ -0,0 +1,27 @@
>>> +Device Tree Bindings for the Arasan SDCHI Controller
>>
>> SDHCI
> Oops. Will be fixed.
>
>>
>>> +
>>> + The bindings follow the mmc[1], clock[2] and interrupt[3] bindings. Only
>>> + deviations are documented here.
>>> +
>>> + [1] Documentation/devicetree/bindings/mmc/mmc.txt
>>> + [2] Documentation/devicetree/bindings/clock/clock-bindings.txt
>>> + [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
>>> +
>>> +Required Properties:
>>> + - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a'
>>> + - reg: From mmc bindings: Register location and length.
>>
>> Actually, reg/interrupts are from the OF core. There's no need to
>> mention them here.
> Tomasz complained when I left those parts out so I added them in v2.
> Since it's there now, I don't mind either way. Let's just agree on one
> way or the other.
>
Binding was Acked-by Rob and that's why I believe this should be fine.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2013-11-27 5:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 16:38 [PATCH v2 1/2] mmc: arasan: Add driver for Arasan SDHCI Soren Brinkmann
2013-10-30 16:38 ` [PATCH v2 2/2] arm: dt: zynq: Add SDHCI nodes Soren Brinkmann
2013-10-30 23:42 ` [PATCH v2 1/2] mmc: arasan: Add driver for Arasan SDHCI Rob Herring
2013-11-06 21:41 ` Sören Brinkmann
[not found] ` <b3f788b3-dfc3-422e-9a74-b796c0fd3207-6DEzpURlfbOXHCJdrdq+zrjjLBE8jN/0@public.gmane.org>
2013-11-12 8:53 ` Michal Simek
2013-11-26 23:22 ` Chris Ball
2013-11-26 23:39 ` Sören Brinkmann
2013-11-27 5:28 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529582E5.4010809@monstr.eu \
--to=monstr@monstr.eu \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=soren.brinkmann@xilinx.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).