From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sourav Poddar Subject: Re: [PATCH 03/17] spi/qspi: parse register by name. Date: Thu, 28 Nov 2013 16:28:07 +0530 Message-ID: <529721BF.4010902@ti.com> References: <1385451313-1875-1-git-send-email-sourav.poddar@ti.com> <1385451313-1875-4-git-send-email-sourav.poddar@ti.com> <20131126103029.GY14725@sirena.org.uk> <5294835D.5090902@ti.com> <20131126122442.GC14725@sirena.org.uk> <5296CA5A.90304@ti.com> <20131128105423.GL14725@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131128105423.GL14725-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On Thursday 28 November 2013 04:24 PM, Mark Brown wrote: > On Thu, Nov 28, 2013 at 10:15:14AM +0530, Sourav Poddar wrote: >> On Tuesday 26 November 2013 05:54 PM, Mark Brown wrote: >>> Do device tree binding changes early on in the series rather than at the >>> end, one of the things that gets reviewed for is binding updates. >>> Your code should also cope with the existing bindings, falling back on >>> the current behaviour if it can't get the names or the extra resources. >> My current code only has a single resouce, hence "*_byname* variants >> was not used. With extra resources, I am switching to "byname" variants, >> So, if a particular resource name is not found, it should just >> bypass that, thinking >> the resource is not required and should not resort to existing bindings.. > That means that if you switch all resources to _byname then the driver > won't find any resources at all and will fail. This will in turn mean > that any device trees that work with the current code wil start failing, > breaking compatibility. I am changing my code to use *byname for all resources. There is no dts available now in mainline using this code. I have added the dts file as patch 15, 16 of this series to take care of this. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html