devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>
Subject: Re: [PATCH] ARM: tegra: convert device tree files to use key defines
Date: Wed, 4 Dec 2013 11:17:41 +0530	[thread overview]
Message-ID: <529EC1FD.2080806@nvidia.com> (raw)
In-Reply-To: <529E393C.4010604@wwwdotorg.org>

On Wednesday 04 December 2013 01:34 AM, Stephen Warren wrote:
> On 12/02/2013 06:09 AM, Laxman Dewangan wrote:
>> Use key code macros for all key code refernced for keys.
>>
>> For tegra20-seaboard.dts and tegra20-harmony.dts:
>>    The key comment for key (16th row and 1st column) is KEY_KPSLASH but
>>    code is 0x004e which is the key code for KEY_KPPLUS. As there other
>>    key exist with KY_KPPLUS, I am assuming key code is wrong and comment
>>    is fine. With this assumption, I am keeping the key code as KEY_KPSLASH.
> This looks reasonable, and I'll apply it soon. What is the patch based
> on? Note that I recently sent a patch to fix the sort order of DT nodes
> in all Tegra DT files, which I'll apply early since it's a cleanup, and
> IIRC some of the KBC nodes may have been moved by that patch, so this
> may conflict. I'll see if I can rebase while applying it.
I worked on linux-next of 20131202.

If there is any issue,  I can generate new patch based on the branch 
which you suggest.

  reply	other threads:[~2013-12-04  5:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 13:09 [PATCH] ARM: tegra: convert device tree files to use key defines Laxman Dewangan
2013-12-03 20:04 ` Stephen Warren
2013-12-04  5:47   ` Laxman Dewangan [this message]
     [not found] ` <1385989797-10879-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-12 20:08   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529EC1FD.2080806@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).