From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644B4EB64D9 for ; Thu, 6 Jul 2023 10:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232159AbjGFK6Y (ORCPT ); Thu, 6 Jul 2023 06:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232672AbjGFK6A (ORCPT ); Thu, 6 Jul 2023 06:58:00 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B462273C for ; Thu, 6 Jul 2023 03:57:08 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-99342a599e9so69317266b.3 for ; Thu, 06 Jul 2023 03:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688641027; x=1691233027; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=092L2NFJ+qxRZMwDDHah31TebKjJ3Qz4BGKrTA614qo=; b=R3ok/LuHATPw7QzcSacAzN6Dedlw7csZlV77VLYrWd091NXov/sOQz1Wij4VxPwE01 XhVv+F+ccfALmC+rQXbggsxkFu0K4TTSgy7pu8CJkvB6WR6cHcHUNCpDtPxmz+7MRIeO GszD07zUvXqDwEFJVHPH5oPObKSvEC9lhNJv9DhOvEzD4KpYPaTiPplKTmbNr4YcVo0H Wyiqx467fBCYXPXiJQVMY8RUlQkjPCw48B23eXVhBUlonks+a3o6u90EB3fGUkurv3ti 0n7rutumD41NSxOb+Y8c7zbNna6V9jwbH2EOyV++X1zb2AOXb4UMyjX1smb9ZedDX82C iaHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688641027; x=1691233027; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=092L2NFJ+qxRZMwDDHah31TebKjJ3Qz4BGKrTA614qo=; b=B/5EU86thwXOYnI5cjXhN8XKdJEyIvcMG6wxNJpyoWYkrmDCylB46SF3oBruh9zUJi /hxwWPV0Dn86qeINzxVBbYQsV0aryflcGpS+OLC+c+FljVoTAH+UA64xdXxAUMSYHYSt aWN5JP0DdXNE15jZZZ2lsxOotLP70L8EMdqa8AdNnLYGKPBoRYY94y/BLSxVLCSoO8mK 9r8VkMlU1FD4Igj3UQTsv9zT7O8B6JvZs0CFTxH7GWkikOsZGYkARUEDKFxQB3+mB3xS 0N15JGJEoM/4S8inyKu5Kd5yOmn878mi4yY3KDCuC7EBXlOK+gwzKy48UMgaDcoHxehV wkUg== X-Gm-Message-State: ABy/qLbpcsEFSN+qXNFQ1kKxa0DYVfCjd5xNGqDXFl6wYHxA/gfGZyBS G2LhwoboDdHhh5E0BFgCc3ScKxOcQTUniryeNZw= X-Google-Smtp-Source: APBJJlH8PRjhwyFUtcv0tpmau9uPFUcjpzmdGl4Chf6J3QkYTVhAUsi+4hAwKnBb/D8IMqz7Ftc2SA== X-Received: by 2002:a17:906:1114:b0:978:a186:464f with SMTP id h20-20020a170906111400b00978a186464fmr1109405eja.39.1688641026853; Thu, 06 Jul 2023 03:57:06 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id gt4-20020a170906f20400b009935aba3a9dsm653682ejb.48.2023.07.06.03.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 03:57:06 -0700 (PDT) Message-ID: <529beea3-3f36-3837-35c4-1efa25d8f1f2@linaro.org> Date: Thu, 6 Jul 2023 12:57:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/3] dt-bindings: power: rpmpd: Remove the SoC specific entries Content-Language: en-US To: Rohit Agarwal , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <1688635218-23779-1-git-send-email-quic_rohiagar@quicinc.com> <1688635218-23779-2-git-send-email-quic_rohiagar@quicinc.com> <318ab229-f29f-e6aa-16b8-79fa09013794@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/07/2023 12:53, Rohit Agarwal wrote: > > On 7/6/2023 4:15 PM, Krzysztof Kozlowski wrote: >> On 06/07/2023 11:20, Rohit Agarwal wrote: >>> Remove the SoC specific entries and add a generic set of defines >>> that can be used by all the SoCs. This will remove the duplicate >>> entries among SoCs. >>> The arrangement of the defines is done according to the frequency >>> used in SoC specific entries in the driver to avoid wastage of >>> memory. >>> >>> Signed-off-by: Rohit Agarwal >>> Suggested-by: Konrad Dybcio >> Please compile kernel with this commit and tell us what is wrong... Even >> if bindings were not an ABI, but they are, this would not work. > Do you mean that individually this commit would fail compilation? > Yes, we would need all the patches together for compilation to be > successful. Yeah, it is not bisectable. Another problem is ABI impact, but I think Konrad covered it. Best regards, Krzysztof