devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>, linus.walleij@linaro.org
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	thierry.reding@gmail.com, grant.likely@linaro.org,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi
Date: Thu, 05 Dec 2013 16:19:47 -0700	[thread overview]
Message-ID: <52A10A13.2020608@wwwdotorg.org> (raw)
In-Reply-To: <52A10932.1040903@wwwdotorg.org>

On 12/05/2013 04:16 PM, Stephen Warren wrote:
> On 12/05/2013 03:57 AM, Laxman Dewangan wrote:
>> The tegra124 pinmux controller is identical to tegra114 with
>> removing some of existing pins from T114 and adding new pins.
> 
> I already sent this patch.

Oh, I do notice one difference between the two patches:

Mine:

> +		reg = <0x70000868 0x148>,	/* Pad control registers */
> +		      <0x70003000 0x40c>;	/* Mux registers */

Yours:

> +		reg = <0x70000868 0x164		/* Pad control registers */
> +		       0x70003000 0x434>;	/* PinMux registers */

Are the increase register lengths in your patch correct? If so, I guess
I'll drop my patch and replace it with yours if you fix up the unit address.

  reply	other threads:[~2013-12-05 23:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 10:57 [PATCH 0/4] pinctrl: tegra: Add pincontrol driver for Tegra124 SoC Laxman Dewangan
     [not found] ` <1386241070-4350-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 10:57   ` [PATCH 1/4] pinctrl: tegra: Add devicetree binding document for Tegra124 Laxman Dewangan
     [not found]     ` <1386241070-4350-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:17       ` Stephen Warren
2013-12-06  6:21         ` Laxman Dewangan
2013-12-05 10:57 ` [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi Laxman Dewangan
2013-12-05 23:16   ` Stephen Warren
2013-12-05 23:19     ` Stephen Warren [this message]
2013-12-06  6:05       ` Laxman Dewangan
2013-12-05 10:57 ` [PATCH 3/4] ARM: tegra: select PINCTRL_TEGRA124 for Tegra124 SoC Laxman Dewangan
     [not found]   ` <1386241070-4350-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:17     ` Stephen Warren
2013-12-12 18:36   ` Stephen Warren
2013-12-05 10:57 ` [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124 Laxman Dewangan
     [not found]   ` <1386241070-4350-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:30     ` Stephen Warren
     [not found]       ` <52A10C7B.8070406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06  6:27         ` Laxman Dewangan
2013-12-06 17:08           ` Stephen Warren
2013-12-06  9:58       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A10A13.2020608@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ldewangan@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).