Re: [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash.

[Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>]

On Tuesday 10 December 2013 11:52 PM, Marek Vasut wrote:
> On Tuesday, December 10, 2013 at 05:11:43 PM, Mark Brown wrote:
>> On Tue, Dec 10, 2013 at 01:49:13PM +0100, Marek Vasut wrote:
>>> My question is, shall we not wait for the new SPI NOR framework to be
>>> well fleshed out and only then implement this controller driver on top
>>> of it ?
>>>
>>> I have a feeling this patchset adds quite a lot of ad-hoc hacks into the
>>> m25p80 driver, which would become dead code once converted to the SPI
>>> NOR framework.
>> There is some stuff that pushes up into the controller in that while the
>> device is in memory mapped mode as far as I can tell it's not safe to do
>> other accesses so if someone's put more than one device on the SPI bus
>> we need to handle interactions there.
> OK, so it's either-or . That seems OK, you might want to have two drivers for
> this ip block, one to handle it as a SPI block and one to handle it as a SPI-NOR
> block. ... that is of course, if these two modes can't work together.
>
the two modes cant work together.
> Best regards,
> Marek Vasut
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html