Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr

[Rajeev kumar <rajeev-dlh.kumar@st.com>]

On 12/11/2013 3:08 PM, Mohit KUMAR wrote:
> DT field name for the phy address changed since kernel 3.10. Set the
> snps,phy-addr to 0xffffffff so that the driver probes for the phy.
>
> Signed-off-by: Mohit Kumar<mohit.kumar@st.com>
> Cc: Pratyush Anand<pratyush.anand@st.com>
> Cc: Viresh Kumar<viresh.linux@gmail.com>
> Cc: spear-devel@list.st.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> ---
>   arch/arm/boot/dts/spear13xx.dtsi |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi
> index 4382547..3518803 100644
> --- a/arch/arm/boot/dts/spear13xx.dtsi
> +++ b/arch/arm/boot/dts/spear13xx.dtsi
> @@ -155,6 +155,7 @@
>
>   		gmac0: eth@e2000000 {
>   			compatible = "st,spear600-gmac";
> +			snps,phy-addr =<0xffffffff>;

Don't you think it should be st,phy-addr =<0xffffffff>, as the 
manufacturer is 'st' as the compatible suggest

~Rajeev


>   			reg =<0xe2000000 0x8000>;
>   			interrupts =<0 33 0x4
>   				      0 34 0x4>;