devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rajeev kumar <rajeev-dlh.kumar@st.com>
To: Mohit KUMAR DCG <Mohit.KUMAR@st.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Pratyush ANAND <pratyush.anand@st.com>,
	Viresh Kumar <viresh.linux@gmail.com>,
	spear-devel <spear-devel@list.st.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr
Date: Wed, 11 Dec 2013 16:44:41 +0530	[thread overview]
Message-ID: <52A84921.4010807@st.com> (raw)
In-Reply-To: <52A847D1.5000409@st.com>


Recheck the subject line, you are not doing any correction.

On 12/11/2013 4:39 PM, Rajeev KUMAR wrote:
> On 12/11/2013 3:08 PM, Mohit KUMAR wrote:
>> DT field name for the phy address changed since kernel 3.10. Set the
>> snps,phy-addr to 0xffffffff so that the driver probes for the phy.
>>
>> Signed-off-by: Mohit Kumar<mohit.kumar@st.com>
>> Cc: Pratyush Anand<pratyush.anand@st.com>
>> Cc: Viresh Kumar<viresh.linux@gmail.com>
>> Cc: spear-devel@list.st.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: devicetree@vger.kernel.org
>> ---
>>    arch/arm/boot/dts/spear13xx.dtsi |    1 +
>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi
>> index 4382547..3518803 100644
>> --- a/arch/arm/boot/dts/spear13xx.dtsi
>> +++ b/arch/arm/boot/dts/spear13xx.dtsi
>> @@ -155,6 +155,7 @@
>>
>>    		gmac0: eth@e2000000 {
>>    			compatible = "st,spear600-gmac";
>> +			snps,phy-addr =<0xffffffff>;
>
> Don't you think it should be st,phy-addr =<0xffffffff>, as the
> manufacturer is 'st' as the compatible suggest
>
> ~Rajeev
>
>
>>    			reg =<0xe2000000 0x8000>;
>>    			interrupts =<0 33 0x4
>>    				      0 34 0x4>;
>

  reply	other threads:[~2013-12-11 11:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1386752447.git.mohit.kumar@st.com>
2013-12-11  9:38 ` [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr Mohit Kumar
2013-12-11 11:09   ` Rajeev kumar
2013-12-11 11:14     ` Rajeev kumar [this message]
2013-12-12  0:39     ` Jingoo Han
2013-12-12  3:59       ` Rajeev kumar
2013-12-12  4:07         ` Chen-Yu Tsai
2013-12-12  5:13           ` Mohit KUMAR DCG

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A84921.4010807@st.com \
    --to=rajeev-dlh.kumar@st.com \
    --cc=Mohit.KUMAR@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=pratyush.anand@st.com \
    --cc=spear-devel@list.st.com \
    --cc=viresh.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).