From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajeev kumar Subject: Re: [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr Date: Wed, 11 Dec 2013 16:44:41 +0530 Message-ID: <52A84921.4010807@st.com> References: <1078549fa412fb34ab2c95a6232096570abee12d.1386752447.git.mohit.kumar@st.com> <52A847D1.5000409@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52A847D1.5000409@st.com> Sender: linux-pci-owner@vger.kernel.org To: Mohit KUMAR DCG Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Pratyush ANAND , Viresh Kumar , spear-devel , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Recheck the subject line, you are not doing any correction. On 12/11/2013 4:39 PM, Rajeev KUMAR wrote: > On 12/11/2013 3:08 PM, Mohit KUMAR wrote: >> DT field name for the phy address changed since kernel 3.10. Set the >> snps,phy-addr to 0xffffffff so that the driver probes for the phy. >> >> Signed-off-by: Mohit Kumar >> Cc: Pratyush Anand >> Cc: Viresh Kumar >> Cc: spear-devel@list.st.com >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: devicetree@vger.kernel.org >> --- >> arch/arm/boot/dts/spear13xx.dtsi | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/spear13xx.dtsi b/arch/arm/boot/dts/spear13xx.dtsi >> index 4382547..3518803 100644 >> --- a/arch/arm/boot/dts/spear13xx.dtsi >> +++ b/arch/arm/boot/dts/spear13xx.dtsi >> @@ -155,6 +155,7 @@ >> >> gmac0: eth@e2000000 { >> compatible = "st,spear600-gmac"; >> + snps,phy-addr =<0xffffffff>; > > Don't you think it should be st,phy-addr =<0xffffffff>, as the > manufacturer is 'st' as the compatible suggest > > ~Rajeev > > >> reg =<0xe2000000 0x8000>; >> interrupts =<0 33 0x4 >> 0 34 0x4>; >