devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] devicetree: macb: Document clock properties
Date: Mon, 16 Dec 2013 10:46:36 +0100	[thread overview]
Message-ID: <52AECBFC.5000207@atmel.com> (raw)
In-Reply-To: <1386972205-32733-1-git-send-email-soren.brinkmann@xilinx.com>

On 13/12/2013 23:03, Soren Brinkmann :
> The macb driver uses the clock bindings. Document the required
> properties, especially the driver specific clock-names.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks.

> ---
>  Documentation/devicetree/bindings/net/macb.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 4ff65047bb9a..70af2ec12b09 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -10,6 +10,10 @@ Required properties:
>  - interrupts: Should contain macb interrupt
>  - phy-mode: String, operation mode of the PHY interface.
>    Supported values are: "mii", "rmii", "gmii", "rgmii".
> +- clock-names: Tuple listing input clock names.
> +	Required elements: 'pclk', 'hclk'
> +	Optional elements: 'tx_clk'
> +- clocks: Phandles to input clocks.
>  
>  Optional properties:
>  - local-mac-address: 6 bytes, mac address
> @@ -22,4 +26,6 @@ Examples:
>  		interrupts = <21>;
>  		phy-mode = "rmii";
>  		local-mac-address = [3a 0e 03 04 05 06];
> +		clock-names = "pclk", "hclk", "tx_clk";
> +		clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
>  	};
> 


-- 
Nicolas Ferre

  reply	other threads:[~2013-12-16  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 22:03 [PATCH] devicetree: macb: Document clock properties Soren Brinkmann
2013-12-16  9:46 ` Nicolas Ferre [this message]
2013-12-19 10:36   ` Michal Simek
2014-01-06 16:10     ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AECBFC.5000207@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).