[PATCH 0/3] Add more device nodes for am43x gp evm.

[PATCH 0/3] Add more device nodes for am43x gp evm.

[Sourav Poddar]

The patch series adds support for enabling gpio, pwm backlight and
matrix gpio keys on am43x-gp-evm.

Done on top of 3.13-rc1 + tero clock series(1) + Afzal's basic gp support(2).

[1]: https://patchwork.kernel.org/patch/3009541/
[2]: https://patchwork.kernel.org/patch/3171761/

Tested on am43x-gp-evm.

There is a some bug while using regulators through backlight
driver on 3.13-rc1. So, tested pwm part with this patch[3].

[3]: http://www.spinics.net/lists/arm-kernel/msg288215.html

Sourav Poddar (3):
  arm: dts: am437x-gp-evm: Enable gpio.
  ARM: dts: am43x-gp-evm: Add matrix gpio keys.
  ARM: dts: am437x-gp-evm: Add pwm backlight support.

 arch/arm/boot/dts/am437x-gp-evm.dts |   53 +++++++++++++++++++++++++++++++++++
 1 files changed, 53 insertions(+), 0 deletions(-)

[PATCH 1/3] arm: dts: am437x-gp-evm: Add pwm backlight support.

[Sourav Poddar]

Add pwm backlight support for gp evm.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 11d93ba..2e79bda 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -12,10 +12,18 @@
 
 #include "am4372.dtsi"
 #include <dt-bindings/pinctrl/am43xx.h>
+#include <dt-bindings/pwm/pwm.h>
 
 / {
 	model = "TI AM437x GP EVM";
 	compatible = "ti,am437x-gp-evm","ti,am4372","ti,am43";
+
+	backlight {
+		compatible = "pwm-backlight";
+		pwms = <&ecap0 0 50000 PWM_POLARITY_INVERTED>;
+		brightness-levels = <0 51 53 56 62 75 101 152 255>;
+		default-brightness-level = <8>;
+	};
 };
 
 &am43xx_pinmux {
@@ -32,6 +40,12 @@
 			0x158 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2)  /* spi0_d1.i2c1_sda  */
 		>;
 	};
+
+	ecap0_pins: backlight_pins {
+		pinctrl-single,pins = <
+			0x164 MUX_MODE0       /* eCAP0_in_PWM0_out.eCAP0_in_PWM0_out MODE0 */
+		>;
+	};
 };
 
 &i2c0 {
@@ -45,3 +59,13 @@
         pinctrl-names = "default";
         pinctrl-0 = <&i2c1_pins>;
 };
+
+&epwmss0 {
+	status = "okay";
+};
+
+&ecap0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&ecap0_pins>;
+};
-- 
1.7.1

[PATCH 2/3] arm: dts: am437x-gp-evm: Enable gpio.

[Sourav Poddar]

Enable gpio3, gpio4, it will be used by gpio matrix keys. Also,
can be used by othe peripherals.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index a581f7d..312a51c 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -69,3 +69,11 @@
 		pinctrl-0 = <&ecap0_pins>;
 	};
 };
+
+&gpio3 {
+	status = "okay";
+};
+
+&gpio4 {
+	status = "okay";
+};
-- 
1.7.1

[PATCH 3/3] arm: dts: am43x-gp-evm: Add matrix gpio keys.

[Sourav Poddar]

Add gpio keys node for am43x gp evm.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts |   21 +++++++++++++++++++++
 1 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 312a51c..9ef6b5a 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -13,6 +13,7 @@
 #include "am4372.dtsi"
 #include <dt-bindings/pinctrl/am43xx.h>
 #include <dt-bindings/pwm/pwm.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "TI AM437x GP EVM";
@@ -24,6 +25,26 @@
 		brightness-levels = <0 51 53 56 62 75 101 152 255>;
 		default-brightness-level = <8>;
 	};
+
+	matrix_keypad: matrix_keypad@0 {
+		compatible = "gpio-matrix-keypad";
+		debounce-delay-ms = <5>;
+		col-scan-delay-us = <2>;
+
+		row-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH /* Bank3, pin21 */
+				&gpio4 3 GPIO_ACTIVE_HIGH /* Bank4, pin3 */
+				&gpio4 2 GPIO_ACTIVE_HIGH>; /* Bank4, pin2 */
+
+		col-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH /* Bank3, pin19 */
+				&gpio3 20 GPIO_ACTIVE_HIGH>; /* Bank3, pin20 */
+
+		linux,keymap = <0x00000201      /* P1 */
+				0x00010202      /* P2 */
+				0x01000067      /* UP */
+				0x0101006a      /* RIGHT */
+				0x02000069      /* LEFT */
+				0x0201006c>;      /* DOWN */
+		};
 };
 
 &am43xx_pinmux {
-- 
1.7.1

Re: [PATCH 0/3] Add more device nodes for am43x gp evm.

[Sourav Poddar]

Hi Benoit,
On Wednesday 27 November 2013 01:01 PM, Sourav Poddar wrote:
> The patch series adds support for enabling gpio, pwm backlight and
> matrix gpio keys on am43x-gp-evm.
>
> Done on top of 3.13-rc1 + tero clock series(1) + Afzal's basic gp support(2).
>
> [1]: https://patchwork.kernel.org/patch/3009541/
> [2]: https://patchwork.kernel.org/patch/3171761/
>
> Tested on am43x-gp-evm.
>
> There is a some bug while using regulators through backlight
> driver on 3.13-rc1. So, tested pwm part with this patch[3].
>
> [3]: http://www.spinics.net/lists/arm-kernel/msg288215.html
>
> Sourav Poddar (3):
>    arm: dts: am437x-gp-evm: Enable gpio.
>    ARM: dts: am43x-gp-evm: Add matrix gpio keys.
>    ARM: dts: am437x-gp-evm: Add pwm backlight support.
>
>   arch/arm/boot/dts/am437x-gp-evm.dts |   53 +++++++++++++++++++++++++++++++++++
>   1 files changed, 53 insertions(+), 0 deletions(-)
>
Gentle pIng on this.

Re: [PATCH 0/3] Add more device nodes for am43x gp evm.

[Sourav Poddar]

Benoit,
On Wednesday 27 November 2013 01:01 PM, Sourav Poddar wrote:
> The patch series adds support for enabling gpio, pwm backlight and
> matrix gpio keys on am43x-gp-evm.
>
> Done on top of 3.13-rc1 + tero clock series(1) + Afzal's basic gp support(2).
>
> [1]: https://patchwork.kernel.org/patch/3009541/
> [2]: https://patchwork.kernel.org/patch/3171761/
>
> Tested on am43x-gp-evm.
>
> There is a some bug while using regulators through backlight
> driver on 3.13-rc1. So, tested pwm part with this patch[3].
>
> [3]: http://www.spinics.net/lists/arm-kernel/msg288215.html
>
> Sourav Poddar (3):
>    arm: dts: am437x-gp-evm: Enable gpio.
>    ARM: dts: am43x-gp-evm: Add matrix gpio keys.
>    ARM: dts: am437x-gp-evm: Add pwm backlight support.
>
>   arch/arm/boot/dts/am437x-gp-evm.dts |   53 +++++++++++++++++++++++++++++++++++
>   1 files changed, 53 insertions(+), 0 deletions(-)
>
Ping on this?

Re: [PATCH 0/3] Add more device nodes for am43x gp evm.

[Benoit Cousson]

Hi Sourav,

On 18/12/2013 18:43, Sourav Poddar wrote:
> Benoit,
> On Wednesday 27 November 2013 01:01 PM, Sourav Poddar wrote:
>> The patch series adds support for enabling gpio, pwm backlight and
>> matrix gpio keys on am43x-gp-evm.
>>
>> Done on top of 3.13-rc1 + tero clock series(1) + Afzal's basic gp
>> support(2).
>>
>> [1]: https://patchwork.kernel.org/patch/3009541/
>> [2]: https://patchwork.kernel.org/patch/3171761/
>>
>> Tested on am43x-gp-evm.
>>
>> There is a some bug while using regulators through backlight
>> driver on 3.13-rc1. So, tested pwm part with this patch[3].
>>
>> [3]: http://www.spinics.net/lists/arm-kernel/msg288215.html
>>
>> Sourav Poddar (3):
>>    arm: dts: am437x-gp-evm: Enable gpio.
>>    ARM: dts: am43x-gp-evm: Add matrix gpio keys.
>>    ARM: dts: am437x-gp-evm: Add pwm backlight support.
>>
>>   arch/arm/boot/dts/am437x-gp-evm.dts |   53
>> +++++++++++++++++++++++++++++++++++
>>   1 files changed, 53 insertions(+), 0 deletions(-)
>>
> Ping on this?

The series looks good, but you should rebase it on top of for_3.14/dts 
that is based on the big cleanup branch Tony has done.
I cannot apply it right now.

Thanks,
Benoit


-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Add more device nodes for am43x gp evm.

[Sourav Poddar]

On Wednesday 18 December 2013 11:19 PM, Benoit Cousson wrote:
> Hi Sourav,
>
> On 18/12/2013 18:43, Sourav Poddar wrote:
>> Benoit,
>> On Wednesday 27 November 2013 01:01 PM, Sourav Poddar wrote:
>>> The patch series adds support for enabling gpio, pwm backlight and
>>> matrix gpio keys on am43x-gp-evm.
>>>
>>> Done on top of 3.13-rc1 + tero clock series(1) + Afzal's basic gp
>>> support(2).
>>>
>>> [1]: https://patchwork.kernel.org/patch/3009541/
>>> [2]: https://patchwork.kernel.org/patch/3171761/
>>>
>>> Tested on am43x-gp-evm.
>>>
>>> There is a some bug while using regulators through backlight
>>> driver on 3.13-rc1. So, tested pwm part with this patch[3].
>>>
>>> [3]: http://www.spinics.net/lists/arm-kernel/msg288215.html
>>>
>>> Sourav Poddar (3):
>>>    arm: dts: am437x-gp-evm: Enable gpio.
>>>    ARM: dts: am43x-gp-evm: Add matrix gpio keys.
>>>    ARM: dts: am437x-gp-evm: Add pwm backlight support.
>>>
>>>   arch/arm/boot/dts/am437x-gp-evm.dts |   53
>>> +++++++++++++++++++++++++++++++++++
>>>   1 files changed, 53 insertions(+), 0 deletions(-)
>>>
>> Ping on this?
>
> The series looks good, but you should rebase it on top of for_3.14/dts 
> that is based on the big cleanup branch Tony has done.
> I cannot apply it right now.
>
Ok. I will rebase it and send you the series, As you can see there is 
one dependency on afzal  basic support patch, as mentioned in
the cover letter. If you are ok with that patch, it has to go first. So, 
if you wish I can work with afzal and send you this
series and afzal patch together.

> Thanks,
> Benoit
>
>

Re: [PATCH 0/3] Add more device nodes for am43x gp evm.

[Benoit Cousson]

On 18/12/2013 19:15, Sourav Poddar wrote:
> On Wednesday 18 December 2013 11:19 PM, Benoit Cousson wrote:
>> Hi Sourav,
>>
>> On 18/12/2013 18:43, Sourav Poddar wrote:
>>> Benoit,
>>> On Wednesday 27 November 2013 01:01 PM, Sourav Poddar wrote:
>>>> The patch series adds support for enabling gpio, pwm backlight and
>>>> matrix gpio keys on am43x-gp-evm.
>>>>
>>>> Done on top of 3.13-rc1 + tero clock series(1) + Afzal's basic gp
>>>> support(2).
>>>>
>>>> [1]: https://patchwork.kernel.org/patch/3009541/
>>>> [2]: https://patchwork.kernel.org/patch/3171761/
>>>>
>>>> Tested on am43x-gp-evm.
>>>>
>>>> There is a some bug while using regulators through backlight
>>>> driver on 3.13-rc1. So, tested pwm part with this patch[3].
>>>>
>>>> [3]: http://www.spinics.net/lists/arm-kernel/msg288215.html
>>>>
>>>> Sourav Poddar (3):
>>>>    arm: dts: am437x-gp-evm: Enable gpio.
>>>>    ARM: dts: am43x-gp-evm: Add matrix gpio keys.
>>>>    ARM: dts: am437x-gp-evm: Add pwm backlight support.
>>>>
>>>>   arch/arm/boot/dts/am437x-gp-evm.dts |   53
>>>> +++++++++++++++++++++++++++++++++++
>>>>   1 files changed, 53 insertions(+), 0 deletions(-)
>>>>
>>> Ping on this?
>>
>> The series looks good, but you should rebase it on top of for_3.14/dts
>> that is based on the big cleanup branch Tony has done.
>> I cannot apply it right now.
>>
> Ok. I will rebase it and send you the series, As you can see there is
> one dependency on afzal  basic support patch, as mentioned in
> the cover letter. If you are ok with that patch, it has to go first. So,
> if you wish I can work with afzal and send you this
> series and afzal patch together.

Yes, go ahead and repost the whole series with the depency.

BTW, could you do that as well with your other series?

Thanks,
Benoit
-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Add more device nodes for am43x gp evm.

[Sourav Poddar]

On Thursday 19 December 2013 12:21 AM, Benoit Cousson wrote:
> On 18/12/2013 19:15, Sourav Poddar wrote:
>> On Wednesday 18 December 2013 11:19 PM, Benoit Cousson wrote:
>>> Hi Sourav,
>>>
>>> On 18/12/2013 18:43, Sourav Poddar wrote:
>>>> Benoit,
>>>> On Wednesday 27 November 2013 01:01 PM, Sourav Poddar wrote:
>>>>> The patch series adds support for enabling gpio, pwm backlight and
>>>>> matrix gpio keys on am43x-gp-evm.
>>>>>
>>>>> Done on top of 3.13-rc1 + tero clock series(1) + Afzal's basic gp
>>>>> support(2).
>>>>>
>>>>> [1]: https://patchwork.kernel.org/patch/3009541/
>>>>> [2]: https://patchwork.kernel.org/patch/3171761/
>>>>>
>>>>> Tested on am43x-gp-evm.
>>>>>
>>>>> There is a some bug while using regulators through backlight
>>>>> driver on 3.13-rc1. So, tested pwm part with this patch[3].
>>>>>
>>>>> [3]: http://www.spinics.net/lists/arm-kernel/msg288215.html
>>>>>
>>>>> Sourav Poddar (3):
>>>>>    arm: dts: am437x-gp-evm: Enable gpio.
>>>>>    ARM: dts: am43x-gp-evm: Add matrix gpio keys.
>>>>>    ARM: dts: am437x-gp-evm: Add pwm backlight support.
>>>>>
>>>>>   arch/arm/boot/dts/am437x-gp-evm.dts |   53
>>>>> +++++++++++++++++++++++++++++++++++
>>>>>   1 files changed, 53 insertions(+), 0 deletions(-)
>>>>>
>>>> Ping on this?
>>>
>>> The series looks good, but you should rebase it on top of for_3.14/dts
>>> that is based on the big cleanup branch Tony has done.
>>> I cannot apply it right now.
>>>
>> Ok. I will rebase it and send you the series, As you can see there is
>> one dependency on afzal  basic support patch, as mentioned in
>> the cover letter. If you are ok with that patch, it has to go first. So,
>> if you wish I can work with afzal and send you this
>> series and afzal patch together.
>
> Yes, go ahead and repost the whole series with the depency.
>
> BTW, could you do that as well with your other series?
>
Yes, I will do that.
> Thanks,
> Benoit