* [PATCH] iio: at91: document ADC clock properties
@ 2013-12-17 16:16 Boris BREZILLON
2013-12-19 15:54 ` Nicolas Ferre
0 siblings, 1 reply; 4+ messages in thread
From: Boris BREZILLON @ 2013-12-17 16:16 UTC (permalink / raw)
To: Rob Landley, Jonathan Cameron, Nicolas Ferre, Arnd Bergmann
Cc: devicetree, linux-doc, linux-kernel, linux-arm-kernel, linux-iio,
Boris BREZILLON
Document the clock properties required by the at91 ADC driver.
Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
---
.../devicetree/bindings/arm/atmel-adc.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
index d106146..9a1175b 100644
--- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
+++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
@@ -5,6 +5,9 @@ Required properties:
<chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
- reg: Should contain ADC registers location and length
- interrupts: Should contain the IRQ line for the ADC
+ - clock-names: tuple listing input clock names.
+ Required elements: "adc_clk", "adc_op_clk".
+ - clocks: phandles to input clocks.
- atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
device
- atmel,adc-startup-time: Startup Time of the ADC in microseconds as
@@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
compatible = "atmel,at91sam9260-adc";
reg = <0xfffb0000 0x100>;
interrupts = <20 4>;
+ clocks = <&adc_clk>, <&adc_op_clk>;
+ clock-names = "adc_clk", "adc_op_clk";
atmel,adc-channel-base = <0x30>;
atmel,adc-channels-used = <0xff>;
atmel,adc-drdy-mask = <0x10000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: at91: document ADC clock properties
2013-12-17 16:16 [PATCH] iio: at91: document ADC clock properties Boris BREZILLON
@ 2013-12-19 15:54 ` Nicolas Ferre
[not found] ` <52B316A9.1060407-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Ferre @ 2013-12-19 15:54 UTC (permalink / raw)
To: Boris BREZILLON, Rob Landley, Jonathan Cameron
Cc: Arnd Bergmann, devicetree, linux-doc, linux-kernel,
linux-arm-kernel, linux-iio
On 17/12/2013 17:16, Boris BREZILLON :
> Document the clock properties required by the at91 ADC driver.
>
> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> .../devicetree/bindings/arm/atmel-adc.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
> index d106146..9a1175b 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
> @@ -5,6 +5,9 @@ Required properties:
> <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
> - reg: Should contain ADC registers location and length
> - interrupts: Should contain the IRQ line for the ADC
> + - clock-names: tuple listing input clock names.
> + Required elements: "adc_clk", "adc_op_clk".
> + - clocks: phandles to input clocks.
> - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
> device
> - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
> compatible = "atmel,at91sam9260-adc";
> reg = <0xfffb0000 0x100>;
> interrupts = <20 4>;
> + clocks = <&adc_clk>, <&adc_op_clk>;
> + clock-names = "adc_clk", "adc_op_clk";
> atmel,adc-channel-base = <0x30>;
> atmel,adc-channels-used = <0xff>;
> atmel,adc-drdy-mask = <0x10000>;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: at91: document ADC clock properties
[not found] ` <52B316A9.1060407-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
@ 2013-12-22 18:05 ` Jonathan Cameron
[not found] ` <52B729FD.7020507-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2013-12-22 18:05 UTC (permalink / raw)
To: Nicolas Ferre, Boris BREZILLON, Rob Landley
Cc: Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-doc-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-iio-u79uwXL29TY76Z2rM5mHXA
On 12/19/13 15:54, Nicolas Ferre wrote:
> On 17/12/2013 17:16, Boris BREZILLON :
>> Document the clock properties required by the at91 ADC driver.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
>
> Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Looks fine to me. I'm just waiting on an ack from a device tree maintainer
(or the 3 weeks to pass so I can pick it up anyway ;)
>
>> ---
>> .../devicetree/bindings/arm/atmel-adc.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> index d106146..9a1175b 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> @@ -5,6 +5,9 @@ Required properties:
>> <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>> - reg: Should contain ADC registers location and length
>> - interrupts: Should contain the IRQ line for the ADC
>> + - clock-names: tuple listing input clock names.
>> + Required elements: "adc_clk", "adc_op_clk".
>> + - clocks: phandles to input clocks.
>> - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>> device
>> - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
>> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
>> compatible = "atmel,at91sam9260-adc";
>> reg = <0xfffb0000 0x100>;
>> interrupts = <20 4>;
>> + clocks = <&adc_clk>, <&adc_op_clk>;
>> + clock-names = "adc_clk", "adc_op_clk";
>> atmel,adc-channel-base = <0x30>;
>> atmel,adc-channels-used = <0xff>;
>> atmel,adc-drdy-mask = <0x10000>;
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: at91: document ADC clock properties
[not found] ` <52B729FD.7020507-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2014-01-11 16:29 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2014-01-11 16:29 UTC (permalink / raw)
To: Nicolas Ferre, Boris BREZILLON, Rob Landley
Cc: Arnd Bergmann, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-doc-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-iio-u79uwXL29TY76Z2rM5mHXA
On 22/12/13 18:05, Jonathan Cameron wrote:
> On 12/19/13 15:54, Nicolas Ferre wrote:
>> On 17/12/2013 17:16, Boris BREZILLON :
>>> Document the clock properties required by the at91 ADC driver.
>>>
>>> Signed-off-by: Boris BREZILLON <b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> Looks fine to me. I'm just waiting on an ack from a device tree maintainer
> (or the 3 weeks to pass so I can pick it up anyway ;)
That's near enough 3 weeks (one day short) so applied to the togreg branch of iio.git.
Thanks
>
>>
>>> ---
>>> .../devicetree/bindings/arm/atmel-adc.txt | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>>> index d106146..9a1175b 100644
>>> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
>>> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>>> @@ -5,6 +5,9 @@ Required properties:
>>> <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>>> - reg: Should contain ADC registers location and length
>>> - interrupts: Should contain the IRQ line for the ADC
>>> + - clock-names: tuple listing input clock names.
>>> + Required elements: "adc_clk", "adc_op_clk".
>>> + - clocks: phandles to input clocks.
>>> - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>>> device
>>> - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
>>> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
>>> compatible = "atmel,at91sam9260-adc";
>>> reg = <0xfffb0000 0x100>;
>>> interrupts = <20 4>;
>>> + clocks = <&adc_clk>, <&adc_op_clk>;
>>> + clock-names = "adc_clk", "adc_op_clk";
>>> atmel,adc-channel-base = <0x30>;
>>> atmel,adc-channels-used = <0xff>;
>>> atmel,adc-drdy-mask = <0x10000>;
>>>
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-11 16:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 16:16 [PATCH] iio: at91: document ADC clock properties Boris BREZILLON
2013-12-19 15:54 ` Nicolas Ferre
[not found] ` <52B316A9.1060407-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-12-22 18:05 ` Jonathan Cameron
[not found] ` <52B729FD.7020507-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-01-11 16:29 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).