From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Alexander Shiyan <shc_work@mail.ru>,
linux-can@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] can: mcp251x: Add device tree support
Date: Mon, 23 Dec 2013 09:01:25 +0100 [thread overview]
Message-ID: <52B7EDD5.6020304@epfl.ch> (raw)
In-Reply-To: <52B7ED3C.8090106@hartkopp.net>
On 12/23/2013 08:58 AM, Oliver Hartkopp wrote:
>
>
> On 23.12.2013 08:14, Florian Vaussard wrote:
>
>> I would say that your patch could be split into several patches, as you
>> introduce several
>> non-DT changes:
>>
>> PATCH 1: use devm_clk_get()
>> PATCH 2: convert to device tree
>> PATCH 3: add frequency sanity check
>>
>
> The patch is already upstream in David Millers net-next tree:
>
> http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=66606aafd8cd6cffbefa463b27e1f16e793e40a9
>
Ah sorry. I should have done the review on Sunday :)
Regards,
Florian
prev parent reply other threads:[~2013-12-23 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 5:01 [PATCH] can: mcp251x: Add device tree support Alexander Shiyan
[not found] ` <1387602101-27851-1-git-send-email-shc_work-JGs/UdohzUI@public.gmane.org>
2013-12-23 7:14 ` Florian Vaussard
2013-12-23 7:58 ` Oliver Hartkopp
2013-12-23 8:01 ` Florian Vaussard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B7EDD5.6020304@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=shc_work@mail.ru \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).