From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation Date: Tue, 07 Jan 2014 22:03:11 +0100 Message-ID: <52CC6B8F.5000404@redhat.com> References: Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Alan Stern Cc: Tony Prisk , Maxime Ripard , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 01/06/2014 04:49 PM, Alan Stern wrote: > On Mon, 6 Jan 2014, Hans de Goede wrote: > >> Add support for ohci-platform instantiation from devicetree, including >> optionally getting clks and a phy from devicetree, and enabling / disabling >> those on power_on / off. >> >> This should allow using ohci-platform from devicetree in various cases. >> Specifically after this commit it can be used for the ohci controller found >> on Allwinner sunxi SoCs. >> >> Signed-off-by: Hans de Goede >> --- >> .../devicetree/bindings/usb/platform-ohci.txt | 25 ++++ >> drivers/usb/host/ohci-platform.c | 146 ++++++++++++++++++--- >> 2 files changed, 151 insertions(+), 20 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/usb/platform-ohci.txt >> >> diff --git a/Documentation/devicetree/bindings/usb/platform-ohci.txt b/Documentation/devicetree/bindings/usb/platform-ohci.txt >> new file mode 100644 >> index 0000000..6846f1c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/platform-ohci.txt >> @@ -0,0 +1,25 @@ >> +Generic Platform OHCI controller >> + >> +Required properties: >> + - compatible: Should be "platform-ohci" >> + - reg: Address range of the ohci registers. >> + - interrupts: Should contain the ohci interrupt. >> + >> +Optional properties: >> + - clocks: array of clocks >> + - clock-names: clock names "ahb" and/or "ohci" > > Where does "ahb" come from, what does it mean, and how is it relevant > to generic platforms? ahb is an ARM specific thing, so your right it does not belong in a generic driver. I'll use clk1 and clk2 as names in my next version. > What about platforms that use 3 clocks? Ah yes I see some platforms have 3 clocks, I'll also add a clk3. Regards, Hans