Re: [PATCH v3 1/2] ohci-platform: Add support for devicetree instantiation

[Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]

On 01/09/2014 10:48 PM, Hans de Goede wrote:
> Hi,
>
> On 01/09/2014 09:14 PM, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 01/09/2014 08:57 PM, Hans de Goede wrote:
>>
>>> Add support for ohci-platform instantiation from devicetree, including
>>> optionally getting clks and a phy from devicetree, and enabling / disabling
>>> those on power_on / off.
>>
>>> This should allow using ohci-platform from devicetree in various cases.
>>> Specifically after this commit it can be used for the ohci controller found
>>> on Allwinner sunxi SoCs.
>>
>>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>> ---
>>>   .../devicetree/bindings/usb/mmio-ohci.txt          |  22 +++
>>>   drivers/usb/host/ohci-platform.c                   | 150
>>> ++++++++++++++++++---
>>>   2 files changed, 152 insertions(+), 20 deletions(-)
>>>   create mode 100644 Documentation/devicetree/bindings/usb/mmio-ohci.txt
>>
>>> diff --git a/Documentation/devicetree/bindings/usb/mmio-ohci.txt
>>> b/Documentation/devicetree/bindings/usb/mmio-ohci.txt
>>> new file mode 100644
>>> index 0000000..9c776ed
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/mmio-ohci.txt
>>> @@ -0,0 +1,22 @@
>>> +Generic MMIO OHCI controller

>>     OHCI controller always uses MMIO, and likewise EHCI. You don't need to
>> specifically mention it.

> Right, I'm only using it here because it is also used in the compatible string.

    Please drop it.

>>> +
>>> +Required properties:
>>> +- compatible : "mmio-ohci"

>>     Likewise, it's not a good name. Why not call it "platform-ohci"?

> Because, as you would have known had you read the entire thread, people objected
> against exactly that name because the "platform" bus thing is a Linux invention,
> and other operating systems don't use the platform nomenclature for non pci
> busses.

    I wonder where were all those people when "xhci-platform" compatible got 
adopted in drivers/usb/host/xhci-plat.c? :-P

    Anyway, I want to suggest "usb-[eo]hci" of which "usb-ehci" binding has 
even already documented in Documentation/devicetree/bindings/usb/usb-ehci.txt.
Both these "compatible" values are used as backups in the multiple described 
bindings of the platform-specific [EO]HCI controllers. I really don't see why 
you should invent anything new (and so poorly named).

> Regards,

> Hans

WBR, Sergei