From: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH v4 0/2] ohci and ehci-platform clks, phy and dt support
Date: Sun, 12 Jan 2014 14:04:26 +0100 [thread overview]
Message-ID: <52D292DA.8010709@gmail.com> (raw)
In-Reply-To: <52D2064B.3010103-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
Hi,
[Cc'ing DT maintainers directly]
On 12.01.2014 04:04, Tony Prisk wrote:
> On 12/01/14 11:30, Alan Stern wrote:
>> On Fri, 10 Jan 2014, Hans de Goede wrote:
>>
>>> Hi,
>>>
>>> On 01/11/2014 12:50 AM, Sergei Shtylyov wrote:
>>>> Hello.
>>>>
>>>> On 01/11/2014 01:46 AM, Hans de Goede wrote:
>>>>
>>>>> Here is v4 of my ohci and ehci-platform clks, phy and dt support
>>>>> patch-set,
>>>>> this version should be 100% ready for merging upstream.
>>>> I see you've decided to completely ignore my opinion. NAK, FWIW.
>>> I'm sorry but the whole prefix thing has become a thing of
>>> -ETOOMUCHBIKESHEDDING,
>>> everyone except you seems to be fine with mmio and and one point in
>>> time we
>>> need to make a decision and move forward.
>> If this isn't beating a dead horse... Maybe everyone can agree on a
>> name like ohci-generic or generic-ohci. That seems like a pretty good
>> description of the hardware that the platform driver can handle.
>>
>> Alan Stern
> I prefer the -generic option, although generic- is equally fine - Having
> said that, I don't really care if it's called mmio either (although this
> does seem less 'descriptive').
Grepping over existing dts files, I can find several occurrences of
"usb-ehci" compatible string:
at91sam9g45.dtsi: compatible =
"atmel,at91sam9g45-ehci", "usb-ehci";
at91sam9x5.dtsi: compatible =
"atmel,at91sam9g45-ehci", "usb-ehci";
omap3.dtsi: compatible = "ti,ehci-omap",
"usb-ehci";
omap4.dtsi: compatible = "ti,ehci-omap",
"usb-ehci";
omap5.dtsi: compatible = "ti,ehci-omap",
"usb-ehci";
sama5d3.dtsi: compatible = "atmel,at91sam9g45-ehci",
"usb-ehci";
spear13xx.dtsi: compatible = "st,spear600-ehci", "usb-ehci";
spear13xx.dtsi: compatible = "st,spear600-ehci", "usb-ehci";
spear3xx.dtsi: compatible = "st,spear600-ehci", "usb-ehci";
spear600.dtsi: compatible = "st,spear600-ehci", "usb-ehci";
spear600.dtsi: compatible = "st,spear600-ehci", "usb-ehci";
tegra114.dtsi: compatible = "nvidia,tegra30-ehci", "usb-ehci";
tegra114.dtsi: compatible = "nvidia,tegra30-ehci", "usb-ehci";
tegra20.dtsi: compatible = "nvidia,tegra20-ehci", "usb-ehci";
tegra20.dtsi: compatible = "nvidia,tegra20-ehci", "usb-ehci";
tegra20.dtsi: compatible = "nvidia,tegra20-ehci", "usb-ehci";
tegra30.dtsi: compatible = "nvidia,tegra30-ehci", "usb-ehci";
tegra30.dtsi: compatible = "nvidia,tegra30-ehci", "usb-ehci";
tegra30.dtsi: compatible = "nvidia,tegra30-ehci", "usb-ehci";
Same for "usb-ohci":
arch/arm/boot/dts/at91rm9200.dtsi: compatible =
"atmel,at91rm9200-ohci", "usb-ohci";
arch/arm/boot/dts/at91sam9260.dtsi: compatible =
"atmel,at91rm9200-ohci", "usb-ohci";
arch/arm/boot/dts/at91sam9263.dtsi: compatible =
"atmel,at91rm9200-ohci", "usb-ohci";
arch/arm/boot/dts/at91sam9g45.dtsi: compatible =
"atmel,at91rm9200-ohci", "usb-ohci";
arch/arm/boot/dts/at91sam9n12.dtsi: compatible =
"atmel,at91rm9200-ohci", "usb-ohci";
arch/arm/boot/dts/at91sam9x5.dtsi: compatible =
"atmel,at91rm9200-ohci", "usb-ohci";
arch/arm/boot/dts/lpc32xx.dtsi: compatible =
"nxp,ohci-nxp", "usb-ohci";
arch/arm/boot/dts/omap3.dtsi: compatible =
"ti,ohci-omap3", "usb-ohci";
arch/arm/boot/dts/omap4.dtsi: compatible =
"ti,ohci-omap3", "usb-ohci";
arch/arm/boot/dts/omap5.dtsi: compatible =
"ti,ohci-omap3", "usb-ohci";
arch/arm/boot/dts/sama5d3.dtsi: compatible =
"atmel,at91rm9200-ohci", "usb-ohci";
arch/arm/boot/dts/spear13xx.dtsi: compatible =
"st,spear600-ohci", "usb-ohci";
arch/arm/boot/dts/spear13xx.dtsi: compatible =
"st,spear600-ohci", "usb-ohci";
arch/arm/boot/dts/spear3xx.dtsi: compatible =
"st,spear600-ohci", "usb-ohci";
arch/arm/boot/dts/spear3xx.dtsi: compatible =
"st,spear600-ohci", "usb-ohci";
arch/arm/boot/dts/spear600.dtsi: compatible =
"st,spear600-ohci", "usb-ohci";
arch/arm/boot/dts/spear600.dtsi: compatible =
"st,spear600-ohci", "usb-ohci";
For "usb-ehci" there is even a documentation file [1], while "usb-ohci"
seems to be undocumented.
[1] Documentation/devicetree/bindings/usb/usb-ehci.txt
Aren't they both something that should be accounted for in this series?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-01-12 13:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 22:46 [PATCH v4 0/2] ohci and ehci-platform clks, phy and dt support Hans de Goede
[not found] ` <1389393980-21183-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-10 22:46 ` [PATCH v4 1/2] ohci-platform: Add support for devicetree instantiation Hans de Goede
2014-01-11 8:37 ` Tony Prisk
[not found] ` <52D102D4.4090302-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2014-01-12 9:17 ` Hans de Goede
2014-01-10 22:46 ` [PATCH v4 2/2] ehci-platform: Add support for clks and phy passed through devicetree Hans de Goede
2014-01-10 23:50 ` [PATCH v4 0/2] ohci and ehci-platform clks, phy and dt support Sergei Shtylyov
[not found] ` <52D0875B.9040102-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-01-10 22:52 ` Hans de Goede
2014-01-10 23:08 ` Bjørn Mork
[not found] ` <878uun1llt.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2014-01-11 0:19 ` Sergei Shtylyov
2014-01-10 23:45 ` Bjørn Mork
[not found] ` <52D0799B.3030401-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-11 0:10 ` Sergei Shtylyov
[not found] ` <52D08BF8.9090709-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-01-10 23:24 ` Hans de Goede
[not found] ` <52D08122.606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-11 1:03 ` Sergei Shtylyov
2014-01-11 22:30 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1401111728150.16586-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-01-12 3:04 ` Tony Prisk
[not found] ` <52D2064B.3010103-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2014-01-12 13:04 ` Tomasz Figa [this message]
[not found] ` <52D292DA.8010709-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-13 15:54 ` Hans de Goede
[not found] ` <52D40C42.2050408-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-13 16:06 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D292DA.8010709@gmail.com \
--to=tomasz.figa-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).