From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain Date: Sun, 12 Jan 2014 20:03:50 +0100 Message-ID: <52D2E716.8040403@gmail.com> References: <1389469372-17199-1-git-send-email-tomasz.figa@gmail.com> <1389469372-17199-2-git-send-email-tomasz.figa@gmail.com> <20140112114717.GA31318@amd.pavel.ucw.cz> <52D287B1.3090106@gmail.com> <20140112185337.GA6810@amd.pavel.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140112185337.GA6810@amd.pavel.ucw.cz> Sender: linux-samsung-soc-owner@vger.kernel.org To: Pavel Machek Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Russell King , Kukjin Kim , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , Bartlomiej Zolnierkiewicz , Stephen Warren , Tomasz Figa List-Id: devicetree@vger.kernel.org On 12.01.2014 19:53, Pavel Machek wrote: > Hi! > >>> Could we get some more descriptive names for the domains? >> >> They are listed like this in user's manual, e.g. DOMAIN_F, DOMAIN_I, >> DOMAIN_G, etc. > > I guessed so. So the manual sucks. Would it be feasible to get it more > descriptive (like "Domain_G (GPU)")? Does the name really matter that much? I changed original ones in this patch simply to make it easier to grep for domain related messages in kernel output (e.g. dmesg | grep domain). It was not the main part of this patch. Also, there are multiple devices in most domains, so that would rather end up being "Domain_I (JPEG, Cam I/F)", "Domain_P (2D, TV Enc., Scaler)", "Domain_F (Rot, Post, LCD)". If you really insist, I can change this, but I fail to see what effect it would really have. Best regards, Tomasz