From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH RFC 01/10] ARM: s3c64xx: pm: Use name field of generic_pm_domain Date: Sun, 12 Jan 2014 20:25:38 +0100 Message-ID: <52D2EC32.6000306@gmail.com> References: <1389469372-17199-1-git-send-email-tomasz.figa@gmail.com> <1389469372-17199-2-git-send-email-tomasz.figa@gmail.com> <20140112192040.GU29039@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140112192040.GU29039@sirena.org.uk> Sender: linux-samsung-soc-owner@vger.kernel.org To: Mark Brown Cc: linux-pm@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Russell King , Pawel Moll , Len Brown , Greg Kroah-Hartman , Tomasz Figa , Ian Campbell , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Rob Herring , Bartlomiej Zolnierkiewicz , Kukjin Kim , Pavel Machek , Kumar Gala , Stephen Warren , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 12.01.2014 20:20, Mark Brown wrote: > On Sat, Jan 11, 2014 at 08:42:43PM +0100, Tomasz Figa wrote: > >> static struct s3c64xx_pm_domain s3c64xx_pm_irom = { >> - .name = "IROM", >> .ena = S3C64XX_NORMALCFG_IROM_ON, >> .pd = { >> + .name = "domain_irom", > > This is nitpicking a bit but are you sure this is actually a > beautification of the name? It's mainly the domain_ bit, mostly since > I'd expect that if it's not obvious that this is a power domain the core > logging would be changed rather than tweaking the name of every power > domain user. > Hmm, that's a really good point. A separate patch might change this and I could drop the "controversial" part of this patch ;). Best regards, Tomasz