devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* ARM: mvebu: dt: add missing alias 'eth3' on Armada XP mv78260
@ 2014-01-12 12:09 Willy Tarreau
       [not found] ` <20140112120924.GA1916-K+wRfnb2/UA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Willy Tarreau @ 2014-01-12 12:09 UTC (permalink / raw)
  To: linux-arm-kernel, devicetree; +Cc: Thomas Petazzoni, Gregory CLEMENT

It was correctly set on mv78460 but not on mv78260, resulting in my
OpenBlocks AX3-4 retrieving only 3 of its 4 MAC addresses from the
boot loader.

Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
---
 arch/arm/boot/dts/armada-xp-mv78260.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
index 6660968..9480cf8 100644
--- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
+++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
@@ -23,6 +23,7 @@
 		gpio0 = &gpio0;
 		gpio1 = &gpio1;
 		gpio2 = &gpio2;
+		eth3 = &eth3;
 	};
 
 	cpus {
@@ -291,7 +292,7 @@
 				interrupts = <91>;
 			};
 
-			ethernet@34000 {
+			eth3: ethernet@34000 {
 				compatible = "marvell,armada-370-neta";
 				reg = <0x34000 0x4000>;
 				interrupts = <14>;
-- 
1.7.12.2.21.g234cd45.dirty

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: ARM: mvebu: dt: add missing alias 'eth3' on Armada XP mv78260
       [not found] ` <20140112120924.GA1916-K+wRfnb2/UA@public.gmane.org>
@ 2014-01-13  9:00   ` Gregory CLEMENT
  2014-01-14  0:53   ` Jason Cooper
  1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2014-01-13  9:00 UTC (permalink / raw)
  To: Willy Tarreau, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: Thomas Petazzoni

Hi Willy,
On 12/01/2014 13:09, Willy Tarreau wrote:
> It was correctly set on mv78460 but not on mv78260, resulting in my
> OpenBlocks AX3-4 retrieving only 3 of its 4 MAC addresses from the
> boot loader.
> 
> Cc: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Cc: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Signed-off-by: Willy Tarreau <w@1wt.eu>

Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>


Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-xp-mv78260.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/armada-xp-mv78260.dtsi b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> index 6660968..9480cf8 100644
> --- a/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> +++ b/arch/arm/boot/dts/armada-xp-mv78260.dtsi
> @@ -23,6 +23,7 @@
>  		gpio0 = &gpio0;
>  		gpio1 = &gpio1;
>  		gpio2 = &gpio2;
> +		eth3 = &eth3;
>  	};
>  
>  	cpus {
> @@ -291,7 +292,7 @@
>  				interrupts = <91>;
>  			};
>  
> -			ethernet@34000 {
> +			eth3: ethernet@34000 {
>  				compatible = "marvell,armada-370-neta";
>  				reg = <0x34000 0x4000>;
>  				interrupts = <14>;
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: ARM: mvebu: dt: add missing alias 'eth3' on Armada XP mv78260
       [not found] ` <20140112120924.GA1916-K+wRfnb2/UA@public.gmane.org>
  2014-01-13  9:00   ` Gregory CLEMENT
@ 2014-01-14  0:53   ` Jason Cooper
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2014-01-14  0:53 UTC (permalink / raw)
  To: Willy Tarreau
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Thomas Petazzoni,
	Gregory CLEMENT

On Sun, Jan 12, 2014 at 01:09:24PM +0100, Willy Tarreau wrote:
> It was correctly set on mv78460 but not on mv78260, resulting in my
> OpenBlocks AX3-4 retrieving only 3 of its 4 MAC addresses from the
> boot loader.
> 
> Cc: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Cc: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
> ---
>  arch/arm/boot/dts/armada-xp-mv78260.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to mvebu/dt-fixes

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-14  0:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12 12:09 ARM: mvebu: dt: add missing alias 'eth3' on Armada XP mv78260 Willy Tarreau
     [not found] ` <20140112120924.GA1916-K+wRfnb2/UA@public.gmane.org>
2014-01-13  9:00   ` Gregory CLEMENT
2014-01-14  0:53   ` Jason Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).