From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCHv5 05/20] cpufreq: cpufreq-cpu0: add dt node parsing for cooling device properties Date: Mon, 13 Jan 2014 11:08:45 -0400 Message-ID: <52D4017D.7050400@ti.com> References: <1384285582-16933-1-git-send-email-eduardo.valentin@ti.com> <1384285582-16933-6-git-send-email-eduardo.valentin@ti.com> <744357E9AAD1214791ACBA4B0B909263011C9A19@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6w14OBBopNRxnkc23Fn6ofb3GQF7Pl6gc" Return-path: In-Reply-To: <744357E9AAD1214791ACBA4B0B909263011C9A19@SHSMSX101.ccr.corp.intel.com> Sender: linux-pm-owner@vger.kernel.org To: "Zhang, Rui" Cc: Eduardo Valentin , "swarren@wwwdotorg.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ian.campbell@citrix.com" , "rob.herring@calxeda.com" , "linux@roeck-us.net" , "wni@nvidia.com" , "grant.likely@linaro.org" , "R, Durgadoss" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , Viresh Kumar , "cpufreq@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" List-Id: devicetree@vger.kernel.org --6w14OBBopNRxnkc23Fn6ofb3GQF7Pl6gc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12-01-2014 10:31, Zhang, Rui wrote: >> +++ b/drivers/cpufreq/Kconfig >> > @@ -186,7 +186,7 @@ config CPU_FREQ_GOV_CONSERVATIVE >> >=20 >> > config GENERIC_CPUFREQ_CPU0 >> > tristate "Generic CPU0 cpufreq driver" >> > - depends on HAVE_CLK && REGULATOR && PM_OPP && OF >> > + depends on HAVE_CLK && REGULATOR && PM_OPP && OF && THERMAL && >> > +CPU_THERMAL > config: make ARCH=3Darm multi_v7_defconfig > All warnings: > warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which=20 > has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ &&=20 > HAVE_CLK && REGULATOR && PM_OPP && OF && THERMAL && CPU_THERMAL) >=20 > I think you need to select THERMAL and CPU_THERMAL instead, right? >=20 Yeah, I think that would be better. I will send you a fix for that. --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --6w14OBBopNRxnkc23Fn6ofb3GQF7Pl6gc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlLUAYEACgkQCXcVR3XQvP1DeAEAtnKafVtyvPO7Aa4m6IQtHL+5 YB9DVIxxyydT4d5qTHAA/jHNYC4nj97SiItKkcKO5lw0d6JhzWkAKc+CB4pBD2Ti =blOg -----END PGP SIGNATURE----- --6w14OBBopNRxnkc23Fn6ofb3GQF7Pl6gc--