From: "Anna, Suman" <s-anna-l0cyMroinI0@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org
Cc: Ohad Ben-Cohen <ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register
Date: Tue, 14 Jan 2014 10:56:26 -0600 [thread overview]
Message-ID: <52D56C3A.7000704@ti.com> (raw)
In-Reply-To: <20140114140440.GA15785-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
Felipe,
On 01/14/2014 08:04 AM, Felipe Balbi wrote:
> Hi again,
>
> On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote:
>>> diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c
>>> index 9f56fb2..194886e 100644
>>> --- a/drivers/hwspinlock/omap_hwspinlock.c
>>> +++ b/drivers/hwspinlock/omap_hwspinlock.c
>>> @@ -101,10 +101,23 @@ static int omap_hwspinlock_probe(struct platform_device *pdev)
>>> if (!io_base)
>>> return -ENOMEM;
>>>
>>> + /*
>>> + * make sure the module is enabled and clocked before reading
>>> + * the module SYSSTATUS register
>>> + */
>>> + pm_runtime_enable(&pdev->dev);
>>> + pm_runtime_get_sync(&pdev->dev);
>
> another thing, you need to check return of pm_runtime_get_sync()
OK, let me check this and your other comment, and the fix is probably a
separate patch.
regards
Suman
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-14 16:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 0:19 [PATCHv4 0/7] omap hwspinlock dt support Suman Anna
2014-01-14 0:19 ` [PATCHv4 1/7] Documentation: dt: add common bindings for hwspinlock Suman Anna
2014-01-14 0:19 ` [PATCHv4 2/7] Documentation: dt: add the omap hwspinlock bindings document Suman Anna
2014-01-14 0:19 ` [PATCHv4 3/7] hwspinlock/core: maintain a list of registered hwspinlock banks Suman Anna
2014-01-14 0:19 ` [PATCHv4 4/7] hwspinlock/core: add common OF helpers Suman Anna
2014-02-07 22:49 ` Bjorn Andersson
2014-02-10 19:14 ` Suman Anna
2014-03-02 5:14 ` Ohad Ben-Cohen
2014-03-02 20:19 ` Bjorn Andersson
2014-03-03 18:46 ` Suman Anna
[not found] ` <CAJAp7Ohf43hbKatCwS5Y1+OfEkJYWOkuhZhW-E_=t_9mfM+UaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-04 17:38 ` Suman Anna
[not found] ` <53160F8F.9060405-l0cyMroinI0@public.gmane.org>
2014-03-13 16:43 ` Josh Cartwright
2014-03-14 8:58 ` Ohad Ben-Cohen
2014-03-14 13:12 ` Ohad Ben-Cohen
2014-03-14 15:23 ` Josh Cartwright
2014-03-15 17:32 ` Ohad Ben-Cohen
2014-09-26 14:40 ` Bjorn Andersson
2014-09-26 16:25 ` Suman Anna
[not found] ` <5425938C.6070007-l0cyMroinI0@public.gmane.org>
2014-10-06 9:44 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbYf3++K4MVXW_n4zj-8fMEee61XG5+r40cW=trapRtJ7w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-06 18:24 ` Suman Anna
[not found] ` <545BBCCB.7030107-l0cyMroinI0@public.gmane.org>
2014-11-07 5:06 ` Ohad Ben-Cohen
[not found] ` <1389658764-39199-1-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2014-01-14 0:19 ` [PATCHv4 5/7] hwspinlock/omap: add support for dt nodes Suman Anna
2014-02-10 19:27 ` [PATCHv4 0/7] omap hwspinlock dt support Suman Anna
2014-02-24 18:14 ` Suman Anna
[not found] ` <530B8C00.8020001-l0cyMroinI0@public.gmane.org>
2014-03-14 20:10 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbZp_RQPCeZJyMRkNTQxaJsnGZ3DnjhSkYYR_-PAE_Kp4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-14 23:58 ` Suman Anna
2014-03-17 14:23 ` Ohad Ben-Cohen
[not found] ` <CAK=WgbZCzA7JovSxnysHCQRZZWc3Z2j3AS8ekpM9fOZ160rmCA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-17 19:10 ` Suman Anna
[not found] ` <532748B7.1080606-l0cyMroinI0@public.gmane.org>
2014-03-17 19:47 ` Ohad Ben-Cohen
2014-03-17 23:46 ` Suman Anna
[not found] ` <53278950.5030905-l0cyMroinI0@public.gmane.org>
2014-03-18 13:35 ` Ohad Ben-Cohen
2014-03-31 22:45 ` Suman Anna
2014-01-14 0:19 ` [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register Suman Anna
2014-01-14 13:10 ` Felipe Balbi
2014-01-14 14:04 ` Felipe Balbi
[not found] ` <20140114140440.GA15785-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-01-14 16:56 ` Anna, Suman [this message]
2014-01-15 23:46 ` Anna, Suman
2014-01-15 23:36 ` [UPDATED PATCHv4 " Suman Anna
2014-01-14 0:19 ` [PATCHv4 7/7] hwspinlock/omap: enable build for AM33xx, AM43xx & DRA7xx Suman Anna
2014-01-14 13:12 ` Felipe Balbi
2014-01-14 16:51 ` Anna, Suman
2014-01-14 17:29 ` Felipe Balbi
2014-01-14 18:36 ` Anna, Suman
2014-01-14 13:12 ` [PATCHv4 0/7] omap hwspinlock dt support Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D56C3A.7000704@ti.com \
--to=s-anna-l0cymroini0@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).