From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sherman Yin Subject: Re: [PATCH v4 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver Date: Fri, 17 Jan 2014 11:59:21 -0800 Message-ID: <52D98B99.5050604@broadcom.com> References: <1386787041-6035-1-git-send-email-syin@broadcom.com> <1387592016-13740-1-git-send-email-syin@broadcom.com> <1387592016-13740-4-git-send-email-syin@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Linus Walleij , "arm@kernel.org" Cc: Mark Brown , Rob Herring , =?ISO-8859-1?Q?Heiko_St=FCbner?= , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Christian Daudt , Russell King , Grant Likely , Matt Porter , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , bcm-kernel-feedback-list , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 14-01-16 05:19 AM, Linus Walleij wrote: > On Sat, Dec 21, 2013 at 3:13 AM, Sherman Yin wrote: > > '> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs. >> >> Signed-off-by: Sherman Yin >> Reviewed-by: Christian Daudt >> Reviewed-by: Matt Porter >> --- >> v4: - PINCTRL selected in Kconfig, PINCTRL_CAPRI selected in bcm_defconfig >> - make use of regmap >> - change CAPRI_PIN_UPDATE from macro to inline function. >> - Handle pull-up strength arg in Ohm instead of enum > > Patch applied. It is really good now! It's late before the merge > window, but you've done a tremendous work on this driver and > I don't want to delay its deployment further. Great, thanks for the support and reviews! > But note: > >> arch/arm/configs/bcm_defconfig | 1 + >> arch/arm/mach-bcm/Kconfig | 1 + > > I've optimistically applied these two hunks of the patch as well, > but if there is any conflict with the ARM SoC tree I will just rebase > the patch and pull these *out*. > > ARM SoC maintainers: be warned if something collides. Ok, will keep an eye on this and fix accordingly. Should be simple fixes. Regards, Sherman