From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support Date: Sat, 18 Jan 2014 17:21:08 +0100 Message-ID: <52DAA9F4.2090601@redhat.com> References: Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , To: Alan Stern , Florian Fainelli Cc: Tony Prisk , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-usb , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 01/17/2014 06:12 PM, Alan Stern wrote: > On Thu, 16 Jan 2014, Florian Fainelli wrote: > >> Le mercredi 15 janvier 2014, 15:26:21 Alan Stern a =EF=BF=BDcrit : >>> On Wed, 15 Jan 2014, Hans de Goede wrote: >>>> Hi All, >>>> >>>> This version of my ohci and ehci-platform clks, phy and dt support >>>> patch-set, really fixes the 2 small bugs Alan found. >>> >>> All okay -- this time I can't find anything to complain about. :-) >> >> There is one minor issue; which is that the ehci binding claims the driv= er >> supports the following optional boolean properties: >> >> - big-endian-regs : boolean, set this for hcds with big-endian registers >> - big-endian-desc : boolean, set this for hcds with big-endian descripto= rs >> - big-endian : boolean, for hcds with big-endian-regs + big-endian-desc >> >> while it does not (yet) so this is misleading. Can we at get that fixed = before >> merging? Copy pasting the PPC ehci driver should do the job. > > I agree it needs to be fixed. This can be done in a follow-up patch, > though. It doesn't have to be in this one because nobody is using > ehci-platform with DT yet. > > A simple copy from the PPC driver isn't quite enough, because the > platform data settings would override the DT values. > ehci_platform_reset has to be changed so that it sets > ehci->big_endian_desc and _mmio if the pdata flags are set, but > otherwise leaves them alone. > > Hans, would you like to write another patch to take care of this? I already took a quick look at this, setting the ehci->big_endian* flags is= easy, the problem is that they won't work unless we also define CONFIG_USB_EHCI_BIG_ENDIAN_DESC and CONFIG_USB_EHCI_BIG_ENDIAN_MMIO I would like to avoid doing something like the ugliness we've with USB_OHCI_HCD_PPC_OF_BE and USB_OHCI_HCD_PPC_OF_LE, which means just selecti= ng these 2 config options whenever USB_EHCI_HCD_PLATFORM is enabled, but I'm not sur= e if that is acceptable. The same goes for the ohci code btw. Regards, Hans --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/groups/opt_out.