From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-kernel@lists.codethink.co.uk, linux-sh@vger.kernel.org,
devicetree@vger.kernel.org, horms+renesas@verge.net.au
Subject: Re: [PATCH 1/6] pci-rcar-gen2: add initial device tree documentation
Date: Mon, 20 Jan 2014 10:43:54 +0000 [thread overview]
Message-ID: <52DCFDEA.4080909@codethink.co.uk> (raw)
In-Reply-To: <52DAD520.5010807@cogentembedded.com>
On 18/01/14 19:25, Sergei Shtylyov wrote:
> Hello.
>
> On 18-01-2014 19:03, Ben Dooks wrote:
>
>> Add initial documentation for the pci-rcar-gen2 driver device tree
>> bindings.
>> This is not yet complete and needs work on the sub-nodes for the PCI bus.
> Why do you think there's a need to document PCI devices? They're
> auto-dicoverable and not usually described in .dts[i] files.
Because the bridge nodes are not auto-discoverable.
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> Cc: linux-sh@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> Cc: horms+renesas@verge.net.au
>> ---
>> Documentation/devicetree/bindings/pci/renessas,pci-r8a7790 | 12
>> ++++++++++++
>
> Just "renesas", not "renessas". Also, .txt file extension is always
> used for bindings as much as I could observe.
Thanks, will fix.
>> 1 file changed, 12 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/pci/renessas,pci-r8a7790
>
>> diff --git
>> a/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790
>> b/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790
>> new file mode 100644
>> index 0000000..65268d9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pci/renessas,pci-r8a7790
>> @@ -0,0 +1,12 @@
>> +Renesas internal AHB to PCI bridge
>> +
>> +This is the bridge used internally to connect the USB controllers to the
>> +AHB.
>> +
>> +Required properties:
>> + - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC
>> + - reg : A list of physical regions to access the device. The first is
>> + the operational registers for the OHCI/EHCI controller and the
>
> What?! This resource doesn't belong to the bridge itself. Perhaps
> it's a candidate for the "ranges" property.
Will look into that one.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-01-20 10:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390057420-13226-1-git-send-email-ben.dooks@codethink.co.uk>
2014-01-18 15:03 ` [PATCH 1/6] pci-rcar-gen2: add initial device tree documentation Ben Dooks
2014-01-18 15:10 ` [PATCH] pci-rcar-gen2: add of match table Ben Dooks
2014-01-18 19:25 ` [PATCH 1/6] pci-rcar-gen2: add initial device tree documentation Sergei Shtylyov
2014-01-20 10:43 ` Ben Dooks [this message]
2014-01-18 15:03 ` [PATCH 2/6] ARM: shmbobile: r8a7790.dtsi: add pci0/1/2 nodes Ben Dooks
2014-01-18 15:03 ` [PATCH 3/6] ARM: shmobile: lager.dts: add pci 0/1/2 Ben Dooks
2014-01-18 15:03 ` [PATCH 4/6] phy-rcar-usb-gen2: add device tree support Ben Dooks
[not found] ` <52DAD3B3.1050807@cogentembedded.com>
2014-01-20 10:49 ` Ben Dooks
2014-01-20 11:19 ` Sergei Shtylyov
2014-02-27 15:54 ` Sergei Shtylyov
2014-02-27 16:03 ` Ben Dooks
2014-02-28 0:03 ` Sergei Shtylyov
[not found] ` <52DD141F.3040704@cogentembedded.com>
2014-01-20 12:24 ` Ben Dooks
2014-01-18 15:03 ` [PATCH 5/6] ARM: shmobile: r8a7790.dtsi: add usbphy node Ben Dooks
2014-01-18 15:03 ` [PATCH 6/6] ARM: shmobile: lager.dtb: add usbphy reference Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DCFDEA.4080909@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).