From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH v2 14/15] watchdog: orion: Allow to build on any Orion platform Date: Tue, 21 Jan 2014 10:41:17 +0100 Message-ID: <52DE40BD.10700@gmail.com> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-15-git-send-email-ezequiel.garcia@free-electrons.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1390295561-3466-15-git-send-email-ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ezequiel Garcia , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Wim Van Sebroeck , Gregory Clement , Lior Amsalem , Tawfik Bayouk , Thomas Petazzoni , Jason Cooper , Jason Gunthorpe , Andrew Lunn List-Id: devicetree@vger.kernel.org On 01/21/14 10:12, Ezequiel Garcia wrote: > After getting rid of all the mach-specific code, it's now possible > to allow builds in any Orion platform. > > Signed-off-by: Ezequiel Garcia > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 5be6e91..1689f72 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -282,7 +282,7 @@ config DAVINCI_WATCHDOG > > config ORION_WATCHDOG > tristate "Orion watchdog" > - depends on ARCH_ORION5X || ARCH_KIRKWOOD || ARCH_DOVE > + depends on PLAT_ORION Ezequiel, while above is true now, I tend to rather have ARCH_MVEBU added here. We really want to get rid of both !ARCH_MVEBU and PLAT_ORION and this unnecessarily will make it more complicated. I haven't checked why ARCH_MVEBU at all added PLAT_ORION as dependency, but IIRC it was just because of a missing mbus driver? If it is just this, we should also remove PLAT_ORION from ARCH_MVEBU to have a clean cut between new common arch and existing sub-archs. Sebastian > select WATCHDOG_CORE > help > Say Y here if to include support for the watchdog timer > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html