From: Nishanth Menon <nm@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: ti-abb: Add support for interleaved LDO registers
Date: Tue, 21 Jan 2014 14:06:25 -0600 [thread overview]
Message-ID: <52DED341.3030503@ti.com> (raw)
In-Reply-To: <20140121185553.GW17314@sirena.org.uk>
On 01/21/2014 12:55 PM, Mark Brown wrote:
> On Thu, Jan 16, 2014 at 01:32:30PM -0600, Nishanth Menon wrote:
>
>> - abb->base = devm_ioremap_resource(dev, res);
>
>> + abb->base = devm_ioremap_nocache(dev, res->start, resource_size(res));
>
> devm_ioremap_resouce() should do the right thing if the memory region is
> marked as uncacheable (with IORESOURCE_CACHEABLE not set). Since I
> can't see the OF code actually setting that flag on the resources unless
> I'm missing something this change isn't needed?
>
Without this change, on DRA7 I get:
[ 0.579500] abb_mpu: 1060 <--> 1210 mV
[ 0.580321] abb_ivahd: 1055 <--> 1250 mV
[ 0.580583] ti_abb 4ae07e20.regulator-abb-dspeve: can't request
region for resource [mem 0x4ae07e20-0x4ae07e2f]
[ 0.580610] ti_abb: probe of 4ae07e20.regulator-abb-dspeve failed
with error -16
[ 0.581216] abb_gpu: 1090 <--> 1280 mV
with the change in the patch, I get:
[ 0.589750] abb_mpu: 1060 <--> 1210 mV
[ 0.590522] abb_ivahd: 1055 <--> 1250 mV
[ 0.591331] abb_dspeve: 1055 <--> 1250 mV
[ 0.592097] abb_gpu: 1090 <--> 1280 mV
reference dts:
https://github.com/nmenon/linux-2.6-playground/blob/abb-rev-v3.14-rc1-vnext-20140121/arch/arm/boot/dts/dra7.dtsi#L562
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-01-21 20:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 19:32 [PATCH] regulator: ti-abb: Add support for interleaved LDO registers Nishanth Menon
2014-01-17 16:08 ` Mark Brown
2014-01-17 16:47 ` Nishanth Menon
2014-01-17 18:00 ` Mark Brown
2014-01-17 18:11 ` Nishanth Menon
2014-01-17 18:38 ` Mark Brown
2014-01-21 18:55 ` Mark Brown
2014-01-21 20:06 ` Nishanth Menon [this message]
2014-01-21 21:56 ` Mark Brown
2014-01-21 22:32 ` Nishanth Menon
2014-01-22 20:19 ` Mark Brown
2014-01-22 20:48 ` Nishanth Menon
2014-01-22 22:25 ` Nishanth Menon
2014-01-23 12:29 ` Mark Brown
2014-01-23 16:20 ` Nishanth Menon
2014-01-23 16:26 ` Nishanth Menon
2014-01-23 16:34 ` Mark Brown
2014-01-23 17:57 ` [PATCH V4] " Nishanth Menon
2014-01-27 19:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DED341.3030503@ti.com \
--to=nm@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).