Re: [RFC PATCH 1/9] drm/exynos: correct timing porch conversion

[Andrzej Hajda <a.hajda@samsung.com>]

Hi,

It seems I have not added description to this patch.
In this patch porch is calculated in compatible way to
drm_display_mode_from_videomode core function.
The way it was seems to me incorrect and it did not work on my hw.

Anyway this patch could be merged with Sean's patches, if he agrees.

Regards
Andrzej

On 01/22/2014 03:35 PM, Andrzej Hajda wrote:
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 8caaac2..b611f33 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -538,21 +538,18 @@ static void fimd_mode_set(struct exynos_drm_manager *mgr,
>  {
>  	struct fimd_context *ctx = mgr->ctx;
>  	struct fimd_mode_data *mode = &ctx->mode;
> -	int hblank, vblank;
>  
> -	vblank = in_mode->crtc_vblank_end - in_mode->crtc_vblank_start;
>  	mode->vtotal = in_mode->crtc_vtotal;
>  	mode->vdisplay = in_mode->crtc_vdisplay;
>  	mode->vsync_len = in_mode->crtc_vsync_end - in_mode->crtc_vsync_start;
> -	mode->vbpd = (vblank - mode->vsync_len) / 2;
> -	mode->vfpd = vblank - mode->vsync_len - mode->vbpd;
> +	mode->vbpd = in_mode->crtc_vtotal - in_mode->crtc_vsync_end;
> +	mode->vfpd = in_mode->crtc_vsync_start - in_mode->crtc_vdisplay;
>  
> -	hblank = in_mode->crtc_hblank_end - in_mode->crtc_hblank_start;
>  	mode->htotal = in_mode->crtc_htotal;
>  	mode->hdisplay = in_mode->crtc_hdisplay;
>  	mode->hsync_len = in_mode->crtc_hsync_end - in_mode->crtc_hsync_start;
> -	mode->hbpd = (hblank - mode->hsync_len) / 2;
> -	mode->hfpd = hblank - mode->hsync_len - mode->hbpd;
> +	mode->hbpd = in_mode->crtc_htotal - in_mode->crtc_hsync_end;
> +	mode->hfpd = in_mode->crtc_hsync_start - in_mode->crtc_hdisplay;
>  
>  	mode->clkdiv = fimd_calc_clkdiv(ctx, in_mode);
>  
>