From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 3/3] net: ethoc: document OF bindings Date: Mon, 27 Jan 2014 18:21:51 +0400 Message-ID: <52E66B7F.3010209@cogentembedded.com> References: <1390795167-6677-1-git-send-email-jcmvbkbc@gmail.com> <1390795167-6677-4-git-send-email-jcmvbkbc@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Max Filippov Cc: linux-xtensa@linux-xtensa.org, netdev , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Chris Zankel , Marc Gauthier , "David S. Miller" , Grant Likely , Rob Herring List-Id: devicetree@vger.kernel.org Hello. On 27-01-2014 18:10, Rob Herring wrote: >> Signed-off-by: Max Filippov >> --- >> .../devicetree/bindings/net/opencores-ethoc.txt | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/opencores-ethoc.txt >> diff --git a/Documentation/devicetree/bindings/net/opencores-ethoc.txt b/Documentation/devicetree/bindings/net/opencores-ethoc.txt >> new file mode 100644 >> index 0000000..f7c6c94 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/opencores-ethoc.txt >> @@ -0,0 +1,25 @@ [...] >> +- reg: Address and length of the register set for the device and of its >> + descriptor memory. >> +- interrupts: Should contain ethoc interrupt. >> + >> +Optional properties: >> +- local-mac-address: 6 bytes, mac address > There's a patch in progress to move all the standard network > properties to a common location, so you can remove this. Haven't you asked me to replace the descriptions of common Ethernet props with the references to the common bindings file? I'd prefer this prop to remain on its place in this case, just the description replaced. Unfortunately, my patch will now have to wait till 3.15 (I guess), the same as these ones. WBR, Sergei