From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] phy-rcar-usb-gen2: add device tree support Date: Wed, 29 Jan 2014 16:26:55 +0400 Message-ID: <52E8F38F.9030609@cogentembedded.com> References: <1390754945-28142-6-git-send-email-ben.dooks@codethink.co.uk> <1390755901-3743-1-git-send-email-ben.dooks@codethink.co.uk> <52E6A436.5090408@cogentembedded.com> <52E6AE32.5050906@codethink.co.uk> <20140129062212.GD23833@verge.net.au> <52E8DAF6.5090105@cogentembedded.com> <20140129122202.GB26253@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140129122202.GB26253-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Horman , Valentine Barshak Cc: Ben Dooks , linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello. On 29-01-2014 16:22, Simon Horman wrote: >>>> [snip] >>>>>> +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { >>>>>> + { .compatible = "renesas,usb-phy-r8a7790", }, >>>>>> + { .compatible = "renesas,rcar-gen2-usb-phy", }, >>>>> Frankly speaking, I don't understand the need for the clearly >>>>> duplicate entries. >>>> Thanks, will look into remove it. >>>> Anyone else have any comments on this? >>> I would like you to leave it there. >>> As we know the r8a7790 is an R-Car Gen2 SoC. But there are other R-Car >>> Gen2 SoCs, such as the r8a7791, they it could plausibly make use of >>> rcar-gen2-usb-phy until the driver is updated with a usb-phy-r8a7791 entry. >> Why not just "update" the driver this way now, may I ask? > Because I don't believe that Ben has access to r8a7791 hardware > to test the change and thus it makes sense to handle it separately. I believe Valentine has already tested the driver with both SoCs. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html