From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kleber Sacilotto de Souza Subject: Re: [PATCH] of: fix PCI bus match for PCIe slots Date: Mon, 03 Feb 2014 13:20:00 -0200 Message-ID: <52EFB3A0.2040407@linux.vnet.ibm.com> References: <1391124584-28847-1-git-send-email-klebers@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Benjamin Herrenschmidt , Brian King , Grant Likely , Rob Herring List-Id: devicetree@vger.kernel.org On 02/01/2014 08:54 PM, Rob Herring wrote: > On Thu, Jan 30, 2014 at 5:29 PM, Kleber Sacilotto de Souza > wrote: >> On IBM pseries systems the device_type device-tree property of a PCIe >> bridge contains the string "pciex". The of_bus_pci_match() function was >> looking only for "pci" on this property, so in such cases the bus >> matching code was falling back to the default bus, causing problems on >> functions that should be using "assigned-addresses" for region address >> translation. This patch fixes the problem by also looking for "pciex" on >> the PCI bus match function. > > Does this need to go to stable? Yes, we need this fix on older kernels as well. > >> Signed-off-by: Kleber Sacilotto de Souza >> --- >> drivers/of/address.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/of/address.c b/drivers/of/address.c >> index d3dd41c..0da2c0f 100644 >> --- a/drivers/of/address.c >> +++ b/drivers/of/address.c >> @@ -102,8 +102,8 @@ static int of_bus_pci_match(struct device_node *np) >> * "vci" is for the /chaos bridge on 1st-gen PCI powermacs >> * "ht" is hypertransport > > How about a comment for who needs pciex. Ok, I will add a comment and send a v2. Thanks, -- Kleber Sacilotto de Souza IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html