devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	grant.likely@linaro.org, devicetree@vger.kernel.org,
	linux-sh@vger.kernel.org, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, nobuhiro.iwamatsu.yj@renesas.com,
	rob@landley.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] sh_eth: add device tree support
Date: Fri, 07 Feb 2014 17:05:17 +0400	[thread overview]
Message-ID: <52F4DA0D.5070009@cogentembedded.com> (raw)
In-Reply-To: <20140207012902.GH19799@verge.net.au>

Hello.

On 07-02-2014 5:29, Simon Horman wrote:

>> Add support of the device tree probing for the Renesas SH-Mobile SoCs
>> documenting the device tree binding as necessary.

>> This work is loosely based on the original patch by Nobuhiro Iwamatsu
>> <nobuhiro.iwamatsu.yj@renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> Acked-by: Simon Horman <horms+renesas@verge.net.au>

>> ---
>> This patch is against DaveM's 'net-next.git' repo but should also apply to the
>> recent 'renesas.git' repo's 'devel' branch. It assumes the patch documenting all
>> Ethernet bindings in one file to be applied as well.
>> Not posting it to netdev@vger.kernel.org this time, or Dave will scold me. :-)

> I would prefer if such orthogonal dependencies weren't introduced.
> I'm quite fine if you want to refactor things, but from my point
> of view it would be nice to tackle such projects after merging new features.

    I don't agree. I didn't want to repeat e.g. all the values for "phy-mode" 
prop for the Nth time, hence I suggested that I'd gather all Ethernet props in 
the single file first and got a consent from the bindings reviewer.

WBR, Sergei


  reply	other threads:[~2014-02-07 13:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 23:58 [PATCH v3] sh_eth: add device tree support Sergei Shtylyov
2014-02-06  8:16 ` Geert Uytterhoeven
2014-02-06 11:52   ` Sergei Shtylyov
2014-02-07  1:29 ` Simon Horman
2014-02-07 13:05   ` Sergei Shtylyov [this message]
2014-02-11 16:08 ` Laurent Pinchart
2014-02-15  1:03   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F4DA0D.5070009@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=horms@verge.net.au \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nobuhiro.iwamatsu.yj@renesas.com \
    --cc=pawel.moll@arm.com \
    --cc=rob@landley.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).