From: Liu Ying <Ying.Liu@freescale.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: devicetree@vger.kernel.org, Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] ARM: dts: i.MX51 babbage: Support diagnostic LED
Date: Mon, 10 Feb 2014 14:24:07 +0800 [thread overview]
Message-ID: <52F87087.4000908@freescale.com> (raw)
In-Reply-To: <1392006579.703394606@f357.i.mail.ru>
On 02/10/2014 12:29 PM, Alexander Shiyan wrote:
> Понедельник, 10 февраля 2014, 11:02 +08:00 от Shawn Guo <shawn.guo@linaro.org>:
>> On Tue, Feb 04, 2014 at 09:57:42PM +0800, Liu Ying wrote:
>>> The D25 LED controlled by gpio on the i.MX51 babbage
>>> board is a diagnostic LED according to the board design.
>>> This patch adds the relevant device tree nodes to the
>>> i.MX51 babbage device tree file to support this LED.
>>>
>>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>>> ---
>>> arch/arm/boot/dts/imx51-babbage.dts | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/imx51-babbage.dts
>> b/arch/arm/boot/dts/imx51-babbage.dts
>>> index be1407c..8d6a74b 100644
>>> --- a/arch/arm/boot/dts/imx51-babbage.dts
>>> +++ b/arch/arm/boot/dts/imx51-babbage.dts
>>> @@ -81,6 +81,17 @@
>>> };
>>> };
>>>
>>> + leds {
>>> + compatible = "gpio-leds";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&led_pin_gpio2_6>;
>>> +
>>> + led-diagnostic {
>>> + label = "diagnostic";
>>> + gpios = <&gpio2 6 0>;
>>
>> Just out of curiosity, how will you use/trigger the led?
>
> And GPIO bindings should be used to specify active level,
> GPIO_ACTIVE_HIGH in this case.
Based on Linux 3.14-rc2, this gives me no single output:
grep GPIO_ACTIVE arch/arm/boot/dts/ -nr | grep imx
So, this patch follows the old approach.
I agree to use GPIO_ACTIVE_HIGH/GPIO_ACTIVE_LOW macros.
How about generating dedicated patch sets for this purpose?
Actually, I had one set for i.MX51 platforms.
Regards,
Liu Ying
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-02-10 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 13:57 [PATCH] ARM: dts: i.MX51 babbage: Support diagnostic LED Liu Ying
2014-02-10 3:02 ` Shawn Guo
2014-02-10 4:29 ` Alexander Shiyan
2014-02-10 6:24 ` Liu Ying [this message]
[not found] ` <52F87087.4000908-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-10 6:31 ` Shawn Guo
2014-02-10 6:05 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F87087.4000908@freescale.com \
--to=ying.liu@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).