From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH v2 1/2] PM / OPP: Allow boost frequency to be looked up from device tree Date: Mon, 10 Feb 2014 10:40:37 +0000 Message-ID: <52F8ACA5.1080409@arm.com> References: <1391786342-11812-1-git-send-email-thomas.ab@samsung.com> <1391786342-11812-2-git-send-email-thomas.ab@samsung.com> <52F50346.7040707@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Thomas Abraham Cc: Sudeep.Holla@arm.com, "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "rjw@rjwysocki.net" , "linux-samsung-soc@vger.kernel.org" , "kgene.kim@samsung.com" , "t.figa@samsung.com" , "l.majewski@samsung.com" , "viresh.kumar@linaro.org" , "thomas.ab@samsung.com" , Nishanth Menon List-Id: devicetree@vger.kernel.org On 08/02/14 05:10, Thomas Abraham wrote: > On Fri, Feb 7, 2014 at 9:31 PM, Sudeep Holla wrote: >> On 07/02/14 15:19, Thomas Abraham wrote: >>> From: Thomas Abraham >>> >>> Commit 6f19efc0 ("cpufreq: Add boost frequency support in core") adds >>> support for CPU boost mode. This patch adds support for finding available >>> boost frequencies from device tree and marking them as usable in boost mode. >>> >>> Cc: Nishanth Menon >>> Cc: Lukasz Majewski >>> Signed-off-by: Thomas Abraham >>> --- >>> drivers/base/power/opp.c | 34 +++++++++++++++++++++++++++++++++- >>> 1 file changed, 33 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c >>> index fa41874..b636826 100644 >>> --- a/drivers/base/power/opp.c >>> +++ b/drivers/base/power/opp.c >>> @@ -628,7 +628,8 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev, >>> struct device_opp *dev_opp; >>> struct dev_pm_opp *opp; >>> struct cpufreq_frequency_table *freq_table; >>> - int i = 0; >>> + int i = 0, j, len, ret; >>> + u32 *boost_freqs = NULL; >>> >>> /* Pretend as if I am an updater */ >>> mutex_lock(&dev_opp_list_lock); >>> @@ -650,10 +651,35 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev, >>> return -ENOMEM; >>> } >>> >>> + if (of_find_property(dev->of_node, "boost-frequency", &len)) { >>> + if (len == 0 || (len & (sizeof(u32) - 1)) != 0) { >>> + dev_err(dev, "%s: invalid boost frequency\n", __func__); >>> + ret = -EINVAL; >>> + goto err_boost; >>> + } >>> + >>> + boost_freqs = kzalloc(len, GFP_KERNEL); >>> + if (!boost_freqs) { >>> + dev_warn(dev, "%s: no memory for boost freq table\n", >>> + __func__); >>> + ret = -ENOMEM; >>> + goto err_boost; >>> + } >>> + of_property_read_u32_array(dev->of_node, "boost-frequency", >>> + boost_freqs, len / sizeof(u32)); >>> + } >>> + >>> list_for_each_entry(opp, &dev_opp->opp_list, node) { >>> if (opp->available) { >>> freq_table[i].driver_data = i; >>> freq_table[i].frequency = opp->rate / 1000; >>> + for (j = 0; j < len / sizeof(u32) && boost_freqs; j++) { >>> + if (boost_freqs[j] == freq_table[i].frequency) { >>> + freq_table[i].driver_data = >>> + CPUFREQ_BOOST_FREQ; >>> + break; >>> + } >>> + } >>> i++; >>> } >>> } >> IIRC you had mentioned that the boost-opp was not limited to be a cpufreq, but >> this change seems to be cpufreq only. > > Yes, but as you have initiated the discussion on extending the OPP > binding, this has been limited to cpufreq only. If the new OPP library > has support for listing boost frequency, this can be migrated to the > new OPP libaray. > Fair enough, just wanted to check as I couldn't get the info following the thread. I might have missed it. Regards, Sudeep