From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas kandagatla Subject: Re: [PATCH v2 1/3] net: stmmac:sti: Add STi SOC glue driver. Date: Tue, 11 Feb 2014 09:01:01 +0000 Message-ID: <52F9E6CD.7040204@st.com> References: <1391770455-24291-1-git-send-email-srinivas.kandagatla@st.com> <1391770525-24349-1-git-send-email-srinivas.kandagatla@st.com> <20140210.144054.2066120014050984537.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140210.144054.2066120014050984537.davem@davemloft.net> Sender: linux-doc-owner@vger.kernel.org To: David Miller Cc: netdev@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rob@landley.net, linux@arm.linux.org.uk, stuart.menefy@st.com, peppe.cavallaro@st.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com List-Id: devicetree@vger.kernel.org Thankyou Dave, I will fix these in next version. On 10/02/14 22:40, David Miller wrote: > From: > Date: Fri, 7 Feb 2014 10:55:25 +0000 > >> + if (dwmac->interface == PHY_INTERFACE_MODE_MII || >> + dwmac->interface == PHY_INTERFACE_MODE_GMII) { > > This is not indented correctly, the first character on the second line should > line up exactly at the column after the openning parenthesis on the first > line. > > The objective is not to indent using only TAB characters, which you > are doing here. > > Rather, the objective is to use the appropriate number of TAB _and_ > space characters necessary to reach the proper column. > >> + const char *rs; >> + err = of_property_read_string(np, "st,tx-retime-src", &rs); > > Please add an empty line after the local variable declaration. > >> + if (!strcasecmp(rs, "clk_125")) >> + dwmac->is_tx_retime_src_clk_125 = true; >> + >> + } > > That empty line is superfluous, please delete it. > > Thanks, srini