[PATCH] export of_irq_count

[PATCH] export of_irq_count

[delicious quinoa]

From: Alan Tull <atull-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>

export of_irq_count so it can be used in drivers that are built
as modules.

Signed-off-by: Alan Tull <atull-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
---
 drivers/of/irq.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 9bcf2cf..5ed19f3 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -393,6 +393,7 @@ int of_irq_count(struct device_node *dev)
 
 	return nr;
 }
+EXPORT_SYMBOL_GPL(of_irq_count);
 
 /**
  * of_irq_to_resource_table - Fill in resource table with node's IRQ info
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] export of_irq_count

[Rob Herring]

On Wed, Feb 12, 2014 at 11:34 AM, delicious quinoa
<delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Alan Tull <atull-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
>
> export of_irq_count so it can be used in drivers that are built
> as modules.

What drivers? Drivers generally should be using resources rather than
this function directly.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] export of_irq_count

[delicious quinoa]

On Wed, Feb 12, 2014 at 12:32 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Wed, Feb 12, 2014 at 11:34 AM, delicious quinoa
> <delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> From: Alan Tull <atull-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
>>
>> export of_irq_count so it can be used in drivers that are built
>> as modules.
>
> What drivers? Drivers generally should be using resources rather than
> this function directly.

It's for the DesignWare GPIO driver I've been upstreaming.  The
DesignWare IP can be configured to be one irq for all the gpios or one
irq per gpio.  I want to support both cases.  So I need to know how
many irqs are specified in the device tree.

Alan
aka
delicious quinoa
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] export of_irq_count

[Rob Herring]

On Wed, Feb 12, 2014 at 12:43 PM, delicious quinoa
<delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Wed, Feb 12, 2014 at 12:32 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Wed, Feb 12, 2014 at 11:34 AM, delicious quinoa
>> <delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> From: Alan Tull <atull-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
>>>
>>> export of_irq_count so it can be used in drivers that are built
>>> as modules.
>>
>> What drivers? Drivers generally should be using resources rather than
>> this function directly.
>
> It's for the DesignWare GPIO driver I've been upstreaming.  The
> DesignWare IP can be configured to be one irq for all the gpios or one
> irq per gpio.  I want to support both cases.  So I need to know how
> many irqs are specified in the device tree.

Okay. You should merge this as part of that then, so:

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] export of_irq_count

[Michal Simek]

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

On 02/12/2014 08:56 PM, Rob Herring wrote:
> On Wed, Feb 12, 2014 at 12:43 PM, delicious quinoa
> <delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Wed, Feb 12, 2014 at 12:32 PM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> On Wed, Feb 12, 2014 at 11:34 AM, delicious quinoa
>>> <delicious.quinoa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>>> From: Alan Tull <atull-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
>>>>
>>>> export of_irq_count so it can be used in drivers that are built
>>>> as modules.
>>>
>>> What drivers? Drivers generally should be using resources rather than
>>> this function directly.
>>
>> It's for the DesignWare GPIO driver I've been upstreaming.  The
>> DesignWare IP can be configured to be one irq for all the gpios or one
>> irq per gpio.  I want to support both cases.  So I need to know how
>> many irqs are specified in the device tree.
> 
> Okay. You should merge this as part of that then, so:
> 
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

I think we should be consistent and there are other methods how
to solve this. I have sent the same patch long time ago.
https://lkml.org/lkml/2013/5/30/265

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]