From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/2] clk: fixed-rate: use full DT node name Date: Fri, 14 Feb 2014 09:43:51 -0700 Message-ID: <52FE47C7.3050509@wwwdotorg.org> References: <1392358613-19962-1-git-send-email-swarren@wwwdotorg.org> <20140214103556.GC9907@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140214103556.GC9907-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Rutland Cc: Mike Turquette , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 02/14/2014 03:35 AM, Mark Rutland wrote: > On Fri, Feb 14, 2014 at 06:16:52AM +0000, Stephen Warren wrote: >> clk-fixed-rate currently names clocks according to a node's name without >> the unit address. When faced with the legal and technically correct DT >> structure below, this causes rgistration attempts for 3 clocks with the >> same name, 2 of which fail. >> >> clocks { >> compatible = "simple-bus"; >> #address-cells = <1>; >> #size-cells = <0>; >> >> clk_mmc: clock@0 { >> compatible = "fixed-clock"; >> reg = <0>; >> ... >> clk_i2c: clock@1 { >> compatible = "fixed-clock"; >> reg = <1>; >> ... >> clk_spi: clock@2 { >> compatible = "fixed-clock"; >> reg = <2>; >> ... > > I'd argue that this case isn't valid. > > The fixed-clock binding doesn't define a reg, yet simple bus binding > implies that the reg property of child nodes should be interpretted as > the same address space as their parent (MMIO in this case?). The > fixed-clock nodes reg proeprties clearly aren't MMIO addresses. > > Additionally, the _requred_ ranges property is missing. Oh, IIRC that was deliberate to indicate that the child address space was disjoint from the parent address space. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html