Re: [PATCH v2 4/5] arm64: dts: renesas: initial Condor board device tree

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 02/19/2018 12:12 PM, Simon Horman wrote:

>>>> Add the initial device  tree for  the R8A77980 SoC based Condor board.
>>>> The board has 1 debug serial port (SCIF0); include support for it, so
>>>> that the serial console can work.
>>>>
>>>> Based on the original (and large) patch by Vladimir Barinov.
>>>>
>>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>
>>>> ---
>>>> Changes in version 2:
>>>> - removed the useless "status" property from the SCIF_CLK node;
>>>> - fixed the memory size;
>>>> - added Geert's tag.
>>>
>>>> --- /dev/null
>>>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
>>>> @@ -0,0 +1,45 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +/*
>>>> + * Device Tree Source for the Condor board
>>>> + *
>>>> + * Copyright (C) 2018 Renesas Electronics Corp.
>>>> + * Copyright (C) 2018 Cogent Embedded, Inc.
>>>> + */
>>>> +
>>>> +/dts-v1/;
>>>> +#include "r8a77980.dtsi"
>>>> +
>>>> +/ {
>>>> +       model = "Renesas Condor board based on r8a77980";
>>>> +       compatible = "renesas,condor", "renesas,r8a77980";
>>>> +
>>>> +       aliases {
>>>> +               serial0 = &scif0;
>>>> +       };
>>>> +
>>>> +       chosen {
>>>> +               stdout-path = "serial0:115200n8";
>>>> +       };
>>>> +
>>>> +       memory@48000000 {
>>>> +               device_type = "memory";
>>>> +               /* first 128MB is reserved for secure area. */
>>>> +               reg = <0 0x48000000 0 0xb8000000>;
>>>
>>> Shouldn't the size be 0x78000000, or is there really 3 GiB of RAM?
>>
>>    Ugh, so I finally mixed up limit and size... :-/
> 
> Thanks, I will apply the following, with the memory corrected to 2 GiB.

   Thank you! Just made sure that whatever is in this node in .dts, the RAM size
ends up being 0x78000000. Probably U-Boot is too smart. :-)

MBR, Sergei