* [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
@ 2023-06-17 17:15 Krzysztof Kozlowski
2023-06-19 13:16 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Panel bindings (boe,nv133fhm-n61) require supply which here actually can
be turned on/off via GPIO control:
sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested on hardware
---
.../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index cfbc4fc1eba9..3d871567cf81 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
clock-frequency = <19200000>;
};
+ vph_pwr: regulator-vph-pwr {
+ compatible = "regulator-fixed";
+ regulator-name = "vph_pwr";
+ regulator-min-microvolt = <3700000>;
+ regulator-max-microvolt = <3700000>;
+ };
+
+ vlcm_3v3: regulator-vlcm-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "vlcm_3v3";
+
+ vin-supply = <&vph_pwr>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
backlight: backlight {
compatible = "pwm-backlight";
pwms = <&sn65dsi86 1000000>;
@@ -419,6 +438,7 @@ aux-bus {
panel: panel {
compatible = "boe,nv133fhm-n61";
backlight = <&backlight>;
+ power-supply = <&vlcm_3v3>;
port {
panel_in_edp: endpoint {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
2023-06-17 17:15 [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply Krzysztof Kozlowski
@ 2023-06-19 13:16 ` Konrad Dybcio
2023-06-19 14:11 ` Steev Klimaszewski
2023-06-24 14:56 ` Caleb Connolly
2023-07-14 5:48 ` Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:16 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, Steev Klimaszewski
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Panel bindings (boe,nv133fhm-n61) require supply which here actually can
> be turned on/off via GPIO control:
>
> sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Not tested on hardware
> ---
+Steev
Konrad
> .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index cfbc4fc1eba9..3d871567cf81 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
> clock-frequency = <19200000>;
> };
>
> + vph_pwr: regulator-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> + };
> +
> + vlcm_3v3: regulator-vlcm-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "vlcm_3v3";
> +
> + vin-supply = <&vph_pwr>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&sn65dsi86 1000000>;
> @@ -419,6 +438,7 @@ aux-bus {
> panel: panel {
> compatible = "boe,nv133fhm-n61";
> backlight = <&backlight>;
> + power-supply = <&vlcm_3v3>;
>
> port {
> panel_in_edp: endpoint {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
2023-06-19 13:16 ` Konrad Dybcio
@ 2023-06-19 14:11 ` Steev Klimaszewski
0 siblings, 0 replies; 6+ messages in thread
From: Steev Klimaszewski @ 2023-06-19 14:11 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On Mon, Jun 19, 2023 at 8:16 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> > Panel bindings (boe,nv133fhm-n61) require supply which here actually can
> > be turned on/off via GPIO control:
> >
> > sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > ---
> >
> > Not tested on hardware
> > ---
> +Steev
>
> Konrad
> > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > index cfbc4fc1eba9..3d871567cf81 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > @@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
> > clock-frequency = <19200000>;
> > };
> >
> > + vph_pwr: regulator-vph-pwr {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vph_pwr";
> > + regulator-min-microvolt = <3700000>;
> > + regulator-max-microvolt = <3700000>;
> > + };
> > +
> > + vlcm_3v3: regulator-vlcm-3v3 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vlcm_3v3";
> > +
> > + vin-supply = <&vph_pwr>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + };
> > +
> > backlight: backlight {
> > compatible = "pwm-backlight";
> > pwms = <&sn65dsi86 1000000>;
> > @@ -419,6 +438,7 @@ aux-bus {
> > panel: panel {
> > compatible = "boe,nv133fhm-n61";
> > backlight = <&backlight>;
> > + power-supply = <&vlcm_3v3>;
> >
> > port {
> > panel_in_edp: endpoint {
I've tested this on my c630, which does have the nv133fhm-n61,
however... the c630 has 2 different LCD panels available, and I do not
have a c630 which has the other panel (anymore). I reached out on IRC
to the person who has it, but have not yet heard back.
-- steev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
2023-06-17 17:15 [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply Krzysztof Kozlowski
2023-06-19 13:16 ` Konrad Dybcio
@ 2023-06-24 14:56 ` Caleb Connolly
2023-06-26 9:47 ` Konrad Dybcio
2023-07-14 5:48 ` Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Caleb Connolly @ 2023-06-24 14:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
On 17/06/2023 17:15, Krzysztof Kozlowski wrote:
> Panel bindings (boe,nv133fhm-n61) require supply which here actually can
> be turned on/off via GPIO control:
>
> sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I've been running an equivalent patch for a while, so
Tested-by: Caleb Connolly <caleb.connolly@linaro.org>
The dsi bridge vcc and vcca supplies are also missing, they're powered
from vreg_l2a_1p2 and controlled by pm8998_gpio 9.
>
> ---
>
> Not tested on hardware
> ---
> .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> index cfbc4fc1eba9..3d871567cf81 100644
> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> @@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
> clock-frequency = <19200000>;
> };
>
> + vph_pwr: regulator-vph-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "vph_pwr";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> + };
> +
> + vlcm_3v3: regulator-vlcm-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "vlcm_3v3";
> +
> + vin-supply = <&vph_pwr>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> +
> + gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> backlight: backlight {
> compatible = "pwm-backlight";
> pwms = <&sn65dsi86 1000000>;
> @@ -419,6 +438,7 @@ aux-bus {
> panel: panel {
> compatible = "boe,nv133fhm-n61";
> backlight = <&backlight>;
> + power-supply = <&vlcm_3v3>;
>
> port {
> panel_in_edp: endpoint {
--
// Caleb (they/them)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
2023-06-24 14:56 ` Caleb Connolly
@ 2023-06-26 9:47 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-06-26 9:47 UTC (permalink / raw)
To: Caleb Connolly, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
On 24.06.2023 16:56, Caleb Connolly wrote:
>
>
> On 17/06/2023 17:15, Krzysztof Kozlowski wrote:
>> Panel bindings (boe,nv133fhm-n61) require supply which here actually can
>> be turned on/off via GPIO control:
>>
>> sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> I've been running an equivalent patch for a while, so
>
> Tested-by: Caleb Connolly <caleb.connolly@linaro.org>
>
> The dsi bridge vcc and vcca supplies are also missing, they're powered
> from vreg_l2a_1p2 and controlled by pm8998_gpio 9.
Mind submitting an incremental patch?
Konrad
>>
>> ---
>>
>> Not tested on hardware
>> ---
>> .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 20 +++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>> index cfbc4fc1eba9..3d871567cf81 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
>> @@ -87,6 +87,25 @@ sn65dsi86_refclk: sn65dsi86-refclk {
>> clock-frequency = <19200000>;
>> };
>>
>> + vph_pwr: regulator-vph-pwr {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vph_pwr";
>> + regulator-min-microvolt = <3700000>;
>> + regulator-max-microvolt = <3700000>;
>> + };
>> +
>> + vlcm_3v3: regulator-vlcm-3v3 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vlcm_3v3";
>> +
>> + vin-supply = <&vph_pwr>;
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> +
>> + gpio = <&tlmm 88 GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + };
>> +
>> backlight: backlight {
>> compatible = "pwm-backlight";
>> pwms = <&sn65dsi86 1000000>;
>> @@ -419,6 +438,7 @@ aux-bus {
>> panel: panel {
>> compatible = "boe,nv133fhm-n61";
>> backlight = <&backlight>;
>> + power-supply = <&vlcm_3v3>;
>>
>> port {
>> panel_in_edp: endpoint {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply
2023-06-17 17:15 [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply Krzysztof Kozlowski
2023-06-19 13:16 ` Konrad Dybcio
2023-06-24 14:56 ` Caleb Connolly
@ 2023-07-14 5:48 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-07-14 5:48 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski
On Sat, 17 Jun 2023 19:15:12 +0200, Krzysztof Kozlowski wrote:
> Panel bindings (boe,nv133fhm-n61) require supply which here actually can
> be turned on/off via GPIO control:
>
> sdm850-lenovo-yoga-c630.dtb: panel: 'power-supply' is a required property
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sdm850-c630: add missing panel supply
commit: 6b0fd355e9572f4db52880e63e0bc74a2a3bfd84
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-14 5:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-17 17:15 [RFT PATCH] arm64: dts: qcom: sdm850-c630: add missing panel supply Krzysztof Kozlowski
2023-06-19 13:16 ` Konrad Dybcio
2023-06-19 14:11 ` Steev Klimaszewski
2023-06-24 14:56 ` Caleb Connolly
2023-06-26 9:47 ` Konrad Dybcio
2023-07-14 5:48 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).