From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leonard Crestez Subject: Re: [PATCH V2 2/4] arm64: dts: imx: add imx8qxp support Date: Mon, 15 Oct 2018 07:30:09 +0000 Message-ID: <52eaa4ac563ad5114ebd99b286cdbe0495dba7ec.camel@nxp.com> References: <1539527419-23613-1-git-send-email-aisheng.dong@nxp.com> <1539527419-23613-3-git-send-email-aisheng.dong@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Content-ID: <15F0858A3D152A47AB4D327CBB63A897@eurprd04.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "festevam@gmail.com" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" Cc: "A.s. Dong" , "mark.rutland@arm.com" , "dongas86@gmail.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Sun, 2018-10-14 at 20:13 -0300, Fabio Estevam wrote: > > + imx8qx-pm { > > + compatible = "fsl,scu-pd"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pd_lsio: lsio-power-domain { > > + #power-domain-cells = <0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pd_lsio_pwm0: lsio-pwm0@191 { > > + reg = <191>; > > The number after @ is in hex, so the reg property should be 0x191. These are SC_R_* resource ids from include/linux/firmware/imx/types.h and they are almost everywhere referenced as decimals. Is this really not acceptable for DT? -- Regards, Leonard