From: Krzysztof Kozlowski <krzk@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v3 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/T2H and RZ/N2H SoCs
Date: Tue, 13 Jan 2026 22:01:41 +0100 [thread overview]
Message-ID: <52ede134-143d-4571-9aef-34bc54d4bc01@kernel.org> (raw)
In-Reply-To: <CAMuHMdUrSUeOFvyX-RhjFV8HfiGtvOvBT-Wd328C4P-j-N0fHw@mail.gmail.com>
On 13/01/2026 20:25, Geert Uytterhoeven wrote:
> On Mon, 12 Jan 2026 at 18:22, Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote:
>> On Mon, Jan 12, 2026 at 4:30 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> On 12/01/2026 15:04, Lad, Prabhakar wrote:
>>>> - if:
>>>> properties:
>>>> compatible:
>>>> contains:
>>>> # SoCs WITH resets but WITHOUT reset-names
>>>> enum:
>>>> - renesas,rcar-gen3-canfd
>>>> - renesas,rcar-gen4-canfd
>>>> then:
>>>> required:
>>>> - resets
>>>> properties:
>>>> reset-names: false
>>>>
>>>
>>> Yes, although now I wonder why do you have such case... There are no
>>> benefits in disallowing reset-names, even for single entries.
>
> Except that I have no idea which of the two names I should use in
> case of renesas,rcar-gen3-canfd and renesas,rcar-gen4-canfd, as
> the hardware documentation doesn't explain that? AFAIU it is just
> a single, common reset for the whole block...
So there is a reason why reset-names should be disallowed :). It's fine
then.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-13 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 12:51 [PATCH v3 0/4] Add CANFD support to R9A09G056/057/077/087 SoCs Prabhakar
2026-01-09 12:51 ` [PATCH v3 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names Prabhakar
2026-01-11 10:08 ` Krzysztof Kozlowski
2026-01-09 12:51 ` [PATCH v3 2/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/V2H(P) and RZ/V2N SoCs Prabhakar
2026-01-09 12:51 ` [PATCH v3 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/T2H and RZ/N2H SoCs Prabhakar
2026-01-11 10:14 ` Krzysztof Kozlowski
2026-01-12 14:04 ` Lad, Prabhakar
2026-01-12 16:30 ` Krzysztof Kozlowski
2026-01-12 17:22 ` Lad, Prabhakar
2026-01-13 19:25 ` Geert Uytterhoeven
2026-01-13 21:01 ` Krzysztof Kozlowski [this message]
2026-01-09 12:51 ` [PATCH v3 4/4] can: rcar_canfd: Add RZ/T2H support Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ede134-143d-4571-9aef-34bc54d4bc01@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox